Upgrade Rails to 8.1.3 and adopt 8.1 framework defaults#70
Merged
Conversation
- Bump rails gem from 8.0.2 to 8.1.3 (latest) - Set config.load_defaults to 8.1 - Regenerate credentials with a fresh master key (previous key was unavailable) - Regenerate js-routes output for Rails 8.1.3 Verified end to end: full test suite green (44 examples, 0 failures), server boots, and root/sign_in/dashboard render via Inertia + Vite. https://claude.ai/code/session_01EWJ3pfYEMxAsg7ue3CFTmb
rubocop-ast 1.46.0 did `require 'prism/translation/parser34'`, but prism 1.9.0 consolidated the per-version parser classes into parser_versions.rb and dropped the standalone files, causing a LoadError on every run (target Ruby 3.4 via .ruby-version). Update rubocop 1.79.1 -> 1.87.0 and rubocop-ast 1.46.0 -> 1.49.1, which no longer require the removed per-version files. rubocop now runs clean (52 files, no offenses); full spec suite still green (44 examples). https://claude.ai/code/session_01EWJ3pfYEMxAsg7ue3CFTmb
The environment was running Ruby 3.3.6 while .ruby-version targeted 3.4.9. Install Ruby 3.4.9 (latest 3.4 series), declare it in the Gemfile via `ruby file: ".ruby-version"`, and regenerate Gemfile.lock so it records RUBY VERSION 3.4.9p82 and bundler enforces it. Verified under 3.4.9: spec suite green (44 examples), rubocop clean (52 files), and the app boots and serves root/sign_in/dashboard (200). https://claude.ai/code/session_01EWJ3pfYEMxAsg7ue3CFTmb
danielpaul
force-pushed
the
claude/rails-upgrade-verify-Id7bA
branch
from
dd98a44 to
115557a
Compare
Two CI jobs were failing: - scan_ruby: bin/brakeman injects --ensure-latest, which exits non-zero when Brakeman is outdated. Bundled 7.1.0 < latest 8.0.4. Update Brakeman to 8.0.4 so the scan passes. - test: the earlier Rails-upgrade work regenerated config/credentials.yml.enc under a new master key, but CI/production hold the original key as a secret and could no longer decrypt it, so db:test:prepare failed loading the environment (MessageEncryptor::InvalidMessage). Restore the original credentials.yml.enc (identical to main) so the existing RAILS_MASTER_KEY secret decrypts it again. Verified locally: brakeman clean (exit 0), rubocop clean, and db:test:prepare + rspec green (44 examples) without a master key. https://claude.ai/code/session_01EWJ3pfYEMxAsg7ue3CFTmb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified end to end: full test suite green (44 examples, 0 failures),
server boots, and root/sign_in/dashboard render via Inertia + Vite.
https://claude.ai/code/session_01EWJ3pfYEMxAsg7ue3CFTmb