Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for versionchange directives #31

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

danirus
Copy link
Owner

@danirus danirus commented Aug 2, 2024

This PR adds better support for version-change directives:

  • versionadded
  • versionchanged
  • deprecated
  • versionremoved

The difference with main is that when the directive does not contain the optional explanatory text it displayed an enclosing empty block. Now, when the explanatory text is not provided, the selector is changed to ${selector}-title-only, via JavaScript. The new selector avoids rendering the enclosing empty block.

@danirus danirus self-assigned this Aug 2, 2024
@danirus danirus merged commit bb7a72b into main Aug 2, 2024
2 checks passed
@danirus danirus deleted the support-versionchange-directives branch August 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant