Skip to content

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Aug 7, 2025

No description provided.

@firewave firewave force-pushed the clang-22 branch 3 times, most recently from 11a30d6 to 8df1a83 Compare August 21, 2025 09:09
@firewave firewave force-pushed the clang-22 branch 5 times, most recently from 8734f77 to abdfbc1 Compare September 8, 2025 11:49
Comment on lines +28 to +30
# TODO: introduced in run-clang-tidy-22
set(CLANG_TIDY_CONFIG "-enable-check-profile")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this is not displayed in the CI. I cannot reproduce the issue locally.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check-profile data is printed to stderr, maybe CI only dump stdout?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine in danmar/simplecpp#514 but that calls it from the shell and not via CMake. I was getting the output when testing it locally but I only used a subset of all files so I suspect something might go awry when all are being scanned. I only had a short look at the run-clang-tidy.py wrapper and saw nothing suspicious.

On a side note - when there are warnings those might get mixed with the profiling output so it seems there might be some flushing missing in the wrapper after the analysis finished.

Copy link

@vbvictor vbvictor Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note - when there are warnings those might get mixed with the profiling output so it seems there might be some flushing missing in the wrapper after the analysis finished.

Stdout is explicitly slushed, maybe we should flush stderr too.

UPD: But if we print to stderr, then there is nothing to mix..?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: But if we print to stderr, then there is nothing to mix..?

No idea. I Need to reproduce it locally. There's just too many things to look into so I didn't get around to it yet.

@firewave
Copy link
Collaborator Author

/home/runner/work/cppcheck/cppcheck/lib/checkclass.cpp:3189:9: error: redundant parentheses around expression [readability-redundant-parentheses,-warnings-as-errors]
 3189 |     if ((true) || !mSettings->severity.isEnabled(Severity::warning)) // NOLINT(readability-simplify-boolean-expr)
      |         ^    ~

I filed llvm/llvm-project#162899 about that.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants