-
Notifications
You must be signed in to change notification settings - Fork 1.5k
updated CI to Clang 22 #7723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
updated CI to Clang 22 #7723
Conversation
11a30d6 to
8df1a83
Compare
8734f77 to
abdfbc1
Compare
| # TODO: introduced in run-clang-tidy-22 | ||
| set(CLANG_TIDY_CONFIG "-enable-check-profile") | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow this is not displayed in the CI. I cannot reproduce the issue locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check-profile data is printed to stderr, maybe CI only dump stdout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine in danmar/simplecpp#514 but that calls it from the shell and not via CMake. I was getting the output when testing it locally but I only used a subset of all files so I suspect something might go awry when all are being scanned. I only had a short look at the run-clang-tidy.py wrapper and saw nothing suspicious.
On a side note - when there are warnings those might get mixed with the profiling output so it seems there might be some flushing missing in the wrapper after the analysis finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note - when there are warnings those might get mixed with the profiling output so it seems there might be some flushing missing in the wrapper after the analysis finished.
Stdout is explicitly slushed, maybe we should flush stderr too.
UPD: But if we print to stderr, then there is nothing to mix..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPD: But if we print to stderr, then there is nothing to mix..?
No idea. I Need to reproduce it locally. There's just too many things to look into so I didn't get around to it yet.
I filed llvm/llvm-project#162899 about that. |
|



No description provided.