Skip to content

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I am not able to do all adjustments to the Japanese readme. I think we should finally drop it.

@firewave firewave force-pushed the cxxopt-xxx branch 4 times, most recently from 61caddf to c44163d Compare August 14, 2025 11:34
@firewave firewave marked this pull request as ready for review August 14, 2025 11:35
Copy link

@danmar
Copy link
Owner

danmar commented Aug 22, 2025

I am not able to do all adjustments to the Japanese readme. I think we should finally drop it.

@fu7mu4 are you able to review the readmeja.md file?

@firewave
Copy link
Collaborator Author

I am not able to do all adjustments to the Japanese readme. I think we should finally drop it.

@fu7mu4 are you able to review the readmeja.md file?

We would also have to update it. And it is already quite outdated.

And it is weird having Japanese documentation if there are not even native "core" developers. We have people who natively speak Swedish/German/etc. and we do maintain those files in those languages (and we shouldn't).

@firewave
Copy link
Collaborator Author

I do not consider the adjustment of the Japanese documentation in the scope of this PR as it has been out-of-sync for ages.

@danmar
Copy link
Owner

danmar commented Aug 28, 2025

I do not consider the adjustment of the Japanese documentation in the scope of this PR as it has been out-of-sync for ages.

I agree.

We would also have to update it.

We have an "owner" that is updating it. We can take a discussion to drop it separately.

@firewave firewave merged commit f8e8765 into danmar:main Aug 28, 2025
63 checks passed
@firewave firewave deleted the cxxopt-xxx branch August 28, 2025 15:37
@firewave
Copy link
Collaborator Author

This causes an incremental daca build to fail because -D_GLIBCXX_DEBUG is part of CXXFLAGS which is now no longer being overwritten. I reverted this for daca in #7777. I will address it for other optimized builds in a different PR.

This is a long-standing shortcoming though and I think it is not even possible to set this using a "release" Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants