Skip to content

do not use stream to read file in FileDataCache::tryload() #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

do not use stream to read file in FileDataCache::tryload() #523

merged 1 commit into from
Aug 29, 2025

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Using Callgrind with the extended selfcheck from #438:

70,470,996 -> 69,235,694 - without system include
1,474,800,488 -> 1,259,681,515 - with system include

CC @glankk

@firewave firewave merged commit 740b2b9 into danmar:master Aug 29, 2025
14 checks passed
@firewave firewave deleted the cache-tryload branch August 29, 2025 16:30
@firewave
Copy link
Collaborator Author

From the current callgrind step:

g++ - 75,902,589 -> 74,990,727
clang++ - 71,211,551 -> 70,436,657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@glankk glankk glankk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @glankk