Skip to content

DAOS-15084 chk: aggregated patch for cat_recovery #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2024
Merged

DAOS-15084 chk: aggregated patch for cat_recovery #13718

merged 6 commits into from
Apr 10, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Feb 1, 2024

It contains all the commits special for feature/cat_recovery branch.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Bug-tracker data:
Ticket title is 'Land CR branch into master'
Status is 'In Progress'
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-15084

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13718/1/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15084_CR_aggregated branch from 916484b to ddf19d8 Compare February 1, 2024 12:17
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13718/2/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15084_CR_aggregated branch from ddf19d8 to 8dc5746 Compare February 2, 2024 13:21
@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 3, 2024 13:14
@Nasf-Fan Nasf-Fan requested review from a team as code owners February 3, 2024 13:14
@Nasf-Fan Nasf-Fan requested review from pavelgritsai and chowes and removed request for a team February 3, 2024 13:14
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15084_CR_aggregated branch from 4c13829 to 530732b Compare April 2, 2024 17:07
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1863/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1775/log

@kccain
Copy link
Contributor

kccain commented Apr 5, 2024

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1863/log

I think it may be partly due to this new issue https://daosio.atlassian.net/browse/DAOS-15598

@kccain
Copy link
Contributor

kccain commented Apr 5, 2024

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1775/log

I think it may be partly due to this new issue https://daosio.atlassian.net/browse/DAOS-15598

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1909/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1594/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/51/execution/node/1578/log

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/53/execution/node/1187/log

@phender
Copy link
Contributor

phender commented Apr 5, 2024

pr + daily test results for https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13718/51/testReport/:

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/53/execution/node/1218/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/53/execution/node/1252/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/53/execution/node/1268/log

Nasf-Fan added 3 commits April 6, 2024 10:30
@Nasf-Fan
Merge branch 'master' into Nasf-Fan/DAOS-15084_CR_aggregated
6432522
@Nasf-Fan
DAOS-15597 control: Log error only on MS leader
6fd3141 
Earlier iterations assumed checkerIsEnabled() would only be called
by MS leader. It can be called during join now, so it is no longer
an error if the node isn't the leader.

Signed-off-by: Kris Jacque <[email protected]>
Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan
DAOS-15084 tests: move insert_objects copy_remote_to_local into ddb
01eefdc 
These functions are only used for ddb tests.

Signed-off-by: Fan Yong <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1275/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1218/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1259/log

@Nasf-Fan
Copy link
Contributor Author

Nasf-Fan commented Apr 7, 2024 •
edited
Loading

ListContainerTest.test_list_containers (Leap 15.5/EL 9/EL 8.8) failed for DAOS-14232.
RbldCascadingFailures.test_cascading_failures (Leap 15.5/EL 9/EL 8.8) failed for DAOS-15460/DAOS-14747/SRE-471.
RbldContRfTest.test_rebuild_with_container_rf (Leap 15.5/EL 9/EL 8.8) failed for DAOS-15440 (proto_query_cb timeout).
RbldDeleteObjects.test_rebuild_delete_records (Leap 15.5/EL 9) failed for DAOS-15440 (proto_query_cb timeout).
RbldReadArrayTest.test_read_array_during_rebuild Leap 15.5/EL 8.8) failed for DAOS-15440 (proto_query_cb timeout).
PerServerFaultDomainTest.test_rf1_healthy failed for DAOS-15440 (proto_query_cb timeout).
DaosCoreTestNvme.test_daos_nvme_recovery md-on-ssd (case 1-6) failed for DAOS-14821.
DaosVolBigIO.test_daos_vol_bigio md-on-ssd failed for DAOS-14517.
IoSysAdmin.test_io_sys_admin md-on-ssd failed for DAOS-14823.
ServerRankFailure.test_server_rank_failure md-on-ssd failed for DAOS-15505.
TargetFailure.test_target_failure md-on-ssd (case 1-4) failed for DAOS-15565.

OSAOnlineReintegration.test_osa_online_reintegration_oclass md-on-ssd failed for DAOS-15514.
VerifyPoolSpace.test_verify_pool_space md-on-ssd failed for DAOS-14546.
PerServerFaultDomainTest.test_rf2_xxx md-on-ssd (case 3/4) failed for DAOS-15440 (proto_query_cb timeout).
DaosVolBigIO.test_daos_vol_bigio failed for DAOS-14517.
TargetFailure.test_target_failure (case 1-4) failed for DAOS-15565.

EcodOfflineRebuild.test_ec_offline_rebuild md-on-ssd (case 3) failed for DAOS-15440 (proto_query_cb timeout).
EcodOnlineRebuild.test_ec_online_rebuild md-on-ssd (case 2) timeout is fake failure, need to increase timeout value.
EcodRunIoConf.test_daos_run_io_conf md-on-ssd failed for DAOS-15059.
EcodDisabledRebuildSingle.test_ec_degrade_single_value md-on-ssd (case 2) failed for DAOS-15208.
EcodDisabledRebuildSingle.test_ec_degrade_single_value md-on-ssd (case 3) failed for DAOS-15440 (proto_query_cb timeout).
EcodFioRebuild.test_ec_online_rebuild_fio md-on-ssd (case 1-9) failed for DAOS-15477.
EcodFioRebuild.test_ec_online_rebuild_fio md-on-ssd (case 10-24) failed for DAOS-15273.
NvmeFault.test_nvme_fault md-on-ssd failed for DAOS-15615 (new).
RbldWidelyStriped.test_rebuild_widely_striped md-on-ssd failed for DAOS-15579 (reported by CR).
EcodOfflineRebuild.test_ec_offline_rebuild failed for DAOS-15461.
EcodDisabledRebuildSingle.test_ec_degrade_single_value (case 2/3) failed for DAOS-15440 (proto_query_cb timeout).
EcodFioRebuild.test_ec_online_rebuild_fio (case 1-9) failed for DAOS-15477.
EcodFioRebuild.test_ec_online_rebuild_fio (case 10-24) failed for DAOS-15273.
EcodServerRestart.test_ec_restart_before_agg (case 1) failed fro DAOS-14549 (reopen).
RbldWidelyStriped.test_rebuild_widely_striped (case 2) failed for DAOS-15440 (proto_query_cb timeout).

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1619/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1573/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1711/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13718/56/execution/node/1665/log

@Nasf-Fan
Copy link
Contributor Author

Nasf-Fan commented Apr 8, 2024

Build#56 full_regression test results:

  1. ListContainerTest.test_list_containers (Leap 15.5/EL 9/EL 8.8) failed for DAOS-14232.
  2. RbldCascadingFailures.test_cascading_failures (Leap 15.5/EL 9/EL 8.8) failed for DAOS-15460/DAOS-14747/SRE-471.
  3. RbldContRfTest.test_rebuild_with_container_rf (Leap 15.5/EL 9/EL 8.8) failed for DAOS-15440 (proto_query_cb timeout).
  4. RbldDeleteObjects.test_rebuild_delete_records (Leap 15.5/EL 9) failed for DAOS-15440 (proto_query_cb timeout).
  5. RbldReadArrayTest.test_read_array_during_rebuild Leap 15.5/EL 8.8) failed for DAOS-15440 (proto_query_cb timeout).
  6. PerServerFaultDomainTest.test_rf1_healthy failed for DAOS-15440 (proto_query_cb timeout).
  7. DaosCoreTestNvme.test_daos_nvme_recovery md-on-ssd (case 1-6) failed for DAOS-14821.
  8. DaosVolBigIO.test_daos_vol_bigio (PMEM/md-on-ssd) failed for DAOS-14517.
  9. IoSysAdmin.test_io_sys_admin md-on-ssd failed for DAOS-14823.
  10. ServerRankFailure.test_server_rank_failure md-on-ssd failed for DAOS-15505.
  11. TargetFailure.test_target_failure (PMEM/md-on-ssd, case 1-4) failed for DAOS-15565.
  12. DfuseFind.test_dfuse_find (PMEM/md-on-ssd) failed for DAOS-15616 (new).
  13. OSAOnlineReintegration.test_osa_online_reintegration_oclass md-on-ssd failed for DAOS-15514.
  14. VerifyPoolSpace.test_verify_pool_space md-on-ssd failed for DAOS-14546.
  15. PerServerFaultDomainTest.test_rf2_xxx md-on-ssd (case 3/4) failed for DAOS-15440 (proto_query_cb timeout).
  16. EcodOfflineRebuild.test_ec_offline_rebuild md-on-ssd (case 3) failed for DAOS-15440 (proto_query_cb timeout).
  17. EcodOnlineRebuild.test_ec_online_rebuild md-on-ssd (case 2) timeout is fake failure, need to increase timeout value.
  18. EcodRunIoConf.test_daos_run_io_conf md-on-ssd failed for DAOS-15059.
  19. EcodDisabledRebuildSingle.test_ec_degrade_single_value md-on-ssd (case 2) failed for DAOS-15208.
  20. EcodDisabledRebuildSingle.test_ec_degrade_single_value md-on-ssd (case 3) failed for DAOS-15440 (proto_query_cb timeout).
  21. EcodFioRebuild.test_ec_online_rebuild_fio (PMEM/md-on-ssd, case 1-9) failed for DAOS-15477.
  22. EcodFioRebuild.test_ec_online_rebuild_fio (PMEM/md-on-ssd, case 10-24) failed for DAOS-15273.
  23. NvmeFault.test_nvme_fault md-on-ssd failed for DAOS-15615 (new).
  24. RbldWidelyStriped.test_rebuild_widely_striped md-on-ssd failed for DAOS-15579 (reported by CR).
  25. EcodOfflineRebuild.test_ec_offline_rebuild failed for DAOS-15461.
  26. EcodDisabledRebuildSingle.test_ec_degrade_single_value (case 2/3) failed for DAOS-15440 (proto_query_cb timeout).
  27. EcodServerRestart.test_ec_restart_before_agg (case 1) failed fro DAOS-14549 (reopen).
  28. RbldWidelyStriped.test_rebuild_widely_striped (case 2) failed for DAOS-15440 (proto_query_cb timeout).

@gnailzenh gnailzenh merged commit b570e54 into master Apr 10, 2024
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-15084_CR_aggregated branch April 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liw liw liw left review comments

@brianjmurrell brianjmurrell brianjmurrell left review comments

@daltonbohning daltonbohning daltonbohning left review comments

@phender phender phender left review comments

@gnailzenh gnailzenh gnailzenh approved these changes

@pavelgritsai pavelgritsai Awaiting requested review from pavelgritsai pavelgritsai is a code owner automatically assigned from daos-stack/go-watchers

@chowes chowes Awaiting requested review from chowes chowes is a code owner automatically assigned from daos-stack/go-watchers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Nasf-Fan @daosbuild1 @jolivier23 @kjacque @daltonbohning @kccain @phender @liw @brianjmurrell @gnailzenh