Skip to content

DAOS-19025 test: enospace.py functional tests is broken with new log … #18391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daltonbohning merged 4 commits into from
Jun 12, 2026
Merged

DAOS-19025 test: enospace.py functional tests is broken with new log … #18391

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ed0e9f
DAOS-19025 test: enospace.py functional tests is broken with new log …
kanard38 May 28, 2026
9a5d8a6
Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…
kanard38 Jun 9, 2026
5dad11d
DAOS-19025 test: enospace.py functional tests is broken with new log …
kanard38 May 28, 2026
cfdf8bd
Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…
kanard38 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tests/ftest/util/general_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""
(C) Copyright 2018-2024 Intel Corporation.
(C) Copyright 2025 Hewlett Packard Enterprise Development LP
(C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP

SPDX-License-Identifier: BSD-2-Clause-Patent
"""
Expand Down Expand Up @@ -545,7 +545,7 @@ def get_errors_count(log, hostlist, file_glob):
"""
# Get the Client side Error from client_log file.
cmd = "cat {} | sed -n -E -e ".format(get_log_file(file_glob))
cmd += r"'/^.+[[:space:]]ERR[[:space:]].+[[:space:]]DER_[^(]+\([^)]+\).+$/"
cmd += r"'/^(ERR|.+[[:space:]]ERR)[[:space:]].+[[:space:]]DER_[^(]+\([^)]+\).+$/"

@grom72 grom72 Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backward compatibility is not required.
I don't know of any situation where we use the master branch test version with release (2.6/2.8) RPMs.

Suggested change
cmd += r"'/^(ERR|.+[[:space:]]ERR)[[:space:]].+[[:space:]]DER_[^(]+\([^)]+\).+$/"
cmd += r"'/^ERR|[[:space:]].+[[:space:]]DER_[^(]+\([^)]+\).+$/"

@daltonbohning daltonbohning Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is technically one case: the interoperability tests :)
But those tests do not call this code

@knard38 knard38 Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backward compatibility is not required. I don't know of any situation where we use the master branch test version with release (2.6/2.8) RPMs.

  • Remove backward compatibility

@knard38 knard38 Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with commit 5dad11d

cmd += r"s/^.+[[:space:]]DER_[^(]+\((-[[:digit:]]+)\).+$/\1/p'"
result = run_remote(log, hostlist, cmd, verbose=False)
errors_count = {}
Expand Down
Loading