Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-10535 tests: Install new daos-tests-internal package #311

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vars/getDAOSPackages.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ String call(String distro, String next_version, String add_daos_pkgs) {

String pkgs
if (env.TEST_RPMS == 'true') {
pkgs = "daos{,-{client,tests,server,serialize}" + add_daos_pkgs + "}"
pkgs = "daos{,-{client,tests-internal,server,serialize}" + add_daos_pkgs + "}"
Comment on lines 28 to +29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this creating an issue that once this is landed, CI will be broken until all DAOS branches and PRs are creating these packages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The daos branches will need to be updated to produce this new package first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. There is a discussion in the PR starting at https://daosio.atlassian.net/browse/DAOS-10535?focusedCommentId=97808

} else {
pkgs = "daos{,-client}"
}
Expand Down