Allow use a different NS than dapr-system #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pepe Gomez <[email protected]>
Signed-off-by: Pepe Gomez <[email protected]>
itek09
changed the title
Signed-off-by: Pepe Gomez <[email protected]>
Signed-off-by: Pepe Gomez <[email protected]>
|
@itek09 thanks for this PR, for some reason I am not getting notifications on this repo. feel free to tag me if you need reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the capability to use a different Dapr namespace, different from "dapr-system". This was already supported but the init container tries to generate the ConfigMap using "dapr-system" without replacement capabilities.
This PR also bring the option to use
disableBuiltinK8sSecretStore, supported by sidecars but not enabled on this chart.