-
Notifications
You must be signed in to change notification settings - Fork 767
feat(pulsar): support subscribeInitialPosition on Pulsar consumer #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ericsyh <[email protected]>
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-pulsar.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-pulsar.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Eric Shen <[email protected]>
@msfussell thx for your review, apply the suggested change and update the same description on dapr/components-contrib@58599e0 |
Stale PR, paging all reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR here is still open, but docs updates lgtm
Stale PR, paging all reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsyh actually, I think we will want to target the v1.16 docs branch. Can you update that?
Then cc @msfussell can you review?
@cicoyle OK, let create a new PR based on the v1.16 branch and close this one. |
Close it since #4637 was merged on branch 1.16 |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Update doc for dapr/components-contrib#3700
Issue reference