Skip to content

feat(pulsar): support subscribeInitialPosition on Pulsar consumer #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ericsyh
Copy link

@ericsyh ericsyh commented Mar 18, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Update doc for dapr/components-contrib#3700

Issue reference

…ubsub/setup-pulsar.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
@ericsyh
Copy link
Author

ericsyh commented Mar 18, 2025

@msfussell thx for your review, apply the suggested change and update the same description on dapr/components-contrib@58599e0

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Mar 24, 2025
@github-actions github-actions bot closed this Mar 31, 2025
@cicoyle cicoyle reopened this Mar 31, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR here is still open, but docs updates lgtm

@cicoyle cicoyle removed the stale label Mar 31, 2025
@cicoyle cicoyle requested a review from msfussell March 31, 2025 20:09
Copy link

github-actions bot commented Apr 6, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 6, 2025
@github-actions github-actions bot closed this Apr 13, 2025
@cicoyle cicoyle reopened this Apr 29, 2025
@cicoyle cicoyle removed the stale label Apr 29, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericsyh actually, I think we will want to target the v1.16 docs branch. Can you update that?

Then cc @msfussell can you review?

@cicoyle cicoyle added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Apr 29, 2025
@ericsyh
Copy link
Author

ericsyh commented Apr 30, 2025

@ericsyh actually, I think we will want to target the v1.16 docs branch. Can you update that?

Then cc @msfussell can you review?

@cicoyle OK, let create a new PR based on the v1.16 branch and close this one.

@ericsyh
Copy link
Author

ericsyh commented Apr 30, 2025

Close it since #4637 was merged on branch 1.16

@ericsyh ericsyh closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants