-
Notifications
You must be signed in to change notification settings - Fork 750
Added local echo conversation component #4587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Whit Waldo <[email protected]>
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
@alicejgibbons I'd appreciate a review of this if you've got the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one verbiage change
daprdocs/content/en/reference/components-reference/supported-conversation/local-echo.md
Outdated
Show resolved
Hide resolved
|
||
{{% alert title="Information" color="warning" %}} | ||
This component is only meant for local validation and testing of a Conversation implementation and does not | ||
actually send the data to any LLM endpoints to perform evaluation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a dupe of the previously resolved note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the text up
…onversation/local-echo.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY
|
||
{{% alert title="Information" color="warning" %}} | ||
This component is only meant for local validation and testing of a Conversation implementation and does not | ||
actually send the data to any LLM endpoints to perform evaluation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a dupe of the previously resolved note?
Fixed repeated text Signed-off-by: Mark Fussell <[email protected]>
Marking Echo stable, since it is only used for local testing Signed-off-by: Mark Fussell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Answered a question for a contributor about the Conversation local echo component and realized it was lacking a page in the reference documentation. In fact, it appears to only be mentioned in passing here. As it's a created component and useful for local testing, I've gone ahead and adding it to the components references.
Issue reference