Skip to content

Added local echo conversation component #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 13, 2025

Conversation

WhitWaldo
Copy link
Contributor

@WhitWaldo WhitWaldo commented Mar 18, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Answered a question for a contributor about the Conversation local echo component and realized it was lacking a page in the reference documentation. In fact, it appears to only be mentioned in passing here. As it's a created component and useful for local testing, I've gone ahead and adding it to the components references.

Issue reference

@WhitWaldo WhitWaldo self-assigned this Mar 18, 2025
@WhitWaldo WhitWaldo requested review from a team as code owners March 18, 2025 19:49
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Mar 24, 2025
@github-actions github-actions bot closed this Apr 1, 2025
@WhitWaldo WhitWaldo removed the stale label Apr 1, 2025
@WhitWaldo WhitWaldo reopened this Apr 1, 2025
Copy link

github-actions bot commented Apr 7, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 7, 2025
@WhitWaldo WhitWaldo removed the stale label Apr 9, 2025
@WhitWaldo
Copy link
Contributor Author

@alicejgibbons I'd appreciate a review of this if you've got the time.

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one verbiage change


{{% alert title="Information" color="warning" %}}
This component is only meant for local validation and testing of a Conversation implementation and does not
actually send the data to any LLM endpoints to perform evaluation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a dupe of the previously resolved note?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the text up

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY


{{% alert title="Information" color="warning" %}}
This component is only meant for local validation and testing of a Conversation implementation and does not
actually send the data to any LLM endpoints to perform evaluation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a dupe of the previously resolved note?

Fixed repeated text

Signed-off-by: Mark Fussell <[email protected]>
Marking Echo stable, since it is only used for local testing

Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 2a93678 into dapr:v1.15 Apr 13, 2025
7 checks passed
@WhitWaldo WhitWaldo deleted the loopback-convo-ref branch April 14, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants