Skip to content

Add docs for AWS Cloudmap and Nameformat name resolution components #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: v1.16
Choose a base branch
from
Open

Add docs for AWS Cloudmap and Nameformat name resolution components #4694

wants to merge 10 commits into from

Conversation

jmenziessmith
Copy link

@jmenziessmith jmenziessmith commented Jun 26, 2025 •
edited
Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add docs supporting the new AWS Cloudmap and Nameformat name resolution components

Issue reference

Please reference the issue this PR will close: #4695

@jmenziessmith jmenziessmith requested review from a team as code owners June 26, 2025 16:55
@msfussell msfussell added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jul 2, 2025
@msfussell msfussell added this to the 1.16 milestone Jul 2, 2025
msfussell
msfussell reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmenziessmith - Amazing contribution. Edits mostly to keep consistency.
Also you will to update dapr/docs/daprdocs/data/components/name_resolution/generic.yaml for the nameformat component and add a new file called dapr/docs/daprdocs/data/components/name_resolution/aws.yaml for Cloudmap component so that these appear in the https://docs.dapr.io/reference/components-reference/supported-name-resolution/ section
In both cases the since will be 1.16 with a v1 version.

jmenziessmith and others added 3 commits July 3, 2025 11:26
@jmenziessmith @msfussell
Apply suggestions from code review
eb43738 
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Jon Menzies-Smith <[email protected]>
@jmenziessmith
Merge branch 'dapr:v1.16' into v1.16
096e1b4
@jmenziessmith
Updates from PR
7963e25 
Signed-off-by: Jon Menzies-Smith <[email protected]>
@jmenziessmith
Copy link
Author

@jmenziessmith - Amazing contribution. Edits mostly to keep consistency. Also you will to update dapr/docs/daprdocs/data/components/name_resolution/generic.yaml for the nameformat component and add a new file called dapr/docs/daprdocs/data/components/name_resolution/aws.yaml for Cloudmap component so that these appear in the https://docs.dapr.io/reference/components-reference/supported-name-resolution/ section In both cases the since will be 1.16 with a v1 version.

@msfussell Thanks for the review , I have added the data and made the other recommended changes

msfussell
msfussell reviewed Jul 9, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmenziessmith - appreciate the updated. This is ready, once the code is checked in

msfussell
msfussell approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Amazing contribution!

@msfussell msfussell removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Aug 29, 2025
marcduiker
marcduiker approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcduiker marcduiker marcduiker approved these changes

@msfussell msfussell msfussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
3 participants
@jmenziessmith @marcduiker @msfussell