Skip to content

Conversation

@ofek
Copy link
Contributor

@ofek ofek commented Mar 8, 2025

This upgrades coincurve to v21.0.0 which brings performance improvements and removes all runtime dependencies!

@ofek ofek mentioned this pull request Mar 8, 2025
@darosior
Copy link
Owner

Thanks! Unfortunately CI is now failing on Coincurve installation:

Installed /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/bip32-4.0-py3.8.egg
Processing dependencies for bip32==4.0
Searching for coincurve<22,>=15.0
Reading https://pypi.org/simple/coincurve/
Downloading https://files.pythonhosted.org/packages/6f/a2/f2a38eb05b747ed3e54e1be33be339d4a14c1f5cc6a6e2b342b5e8160d51/coincurve-21.0.0.tar.gz#sha256=8b37ce4265a82bebf0e796e21a769e56fdbf8420411ccbe3fafee4ed75b6a6e5
Best match: coincurve 21.0.0
Processing coincurve-21.0.0.tar.gz
error: Couldn't find a setup script in /tmp/easy_install-shrrtm46/coincurve-21.0.0.tar.gz
Error: Process completed with exit code 1.

@ofek
Copy link
Contributor Author

ofek commented Mar 10, 2025

I can make CI pass if you want but how long do you plan to support 3.8?

@darosior
Copy link
Owner

I don't think this is related to 3.8. It also fails on the 3.10 job, and i suspect it would fail on all of them given enough time.

@ofek
Copy link
Contributor Author

ofek commented Mar 11, 2025

I think I found the issue, can you please run CI once more?

The Python packaging ecosystem has standardized on the interface for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631). As a result, the execution of setup.py files is now deprecated.

@darosior
Copy link
Owner

Unfortunate that the CI doesn't run automatically anymore, just kicked it let's see.

@ofek
Copy link
Contributor Author

ofek commented Mar 12, 2025

Yay all green now!

@darosior
Copy link
Owner

Hi, just letting you know i did not forget about this.

@dni
Copy link

dni commented Apr 2, 2025

bump :)

@prusnak
Copy link

prusnak commented Nov 6, 2025

Please merge and make a new release on PyPI, this is making the library unusable with modern python versions.

If you are not able to merge in time (it's been 8 months since the coincurve 21.x release), maybe just let's just drop the upper bound, so we do not hit the same issue again next time coincurve is updated.

@darosior
Copy link
Owner

darosior commented Nov 8, 2025 via email

@prusnak
Copy link

prusnak commented Nov 8, 2025

i think i'll also drop the upper bound.

that would be awesome!

coincurve are bumping their major version aggressively even though there are no API breaking changes so this makes sense.

@darosior
Copy link
Owner

I cherry-picked your second commit in a PR dedicated to properly move the project away from our deprecated ways: #49. I plan to make a first release for the project structure change, followed by merging the Coincurve version bump and a second release.

darosior added a commit that referenced this pull request Nov 13, 2025
Thanks to Ofek Lev for the original PR to upgrade to the latest Coincurve: #47

Co-Authored-By: Ofek Lev <[email protected]>
@darosior
Copy link
Owner

darosior commented Nov 13, 2025

I have a separate PR which supersedes this one to upgrade to Coincurve. Unfortunately it seems to fail CI because of ofek/coincurve#187 at the moment. I'll get a release PR together to be ready to publish a new release as soon as it's resolved.

darosior added a commit that referenced this pull request Nov 13, 2025
Thanks to Ofek Lev for the original PR to upgrade to the latest Coincurve: #47

Co-Authored-By: Ofek Lev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants