-
Notifications
You must be signed in to change notification settings - Fork 89
[jnigen] Kotlin interfaces with suspend methods #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| jni | Breaking | 0.15.2 | 0.15.3-wip | 0.16.0 Got "0.15.3-wip" expected >= "0.16.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Methodextension_ConcreteImplClosureDef,_AbstractImplFactoryArg,_ConcreteImplClosureCtorArg, and_ConcreteImplMethod_ConcreteImplMethodis where the interesting stuff happens. It constructs aKotlinContinuation, invokes the user's method, then passes the future toKotlinContinuation.resumeWithFuture.KotlinContinuationis a new internal class with some helpers for resuming continuations.kotlin/Result$Failure, or a value wrapped in akotlin/Result. The existing suspend function invocation logic didn't handle that last case, so I also changed_MethodGeneratorto add support for this case. I don't know how common this is in practice though.Fixes #558