[interop] Resolved Namespace typedef and exception improvements
#459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improved exception for not finding type - resolved def if cannot find file in path/module (i.e maybe a module already resolved by ts/node)
srujzs
reviewed
Aug 25, 2025
| final transformer = | ||
| if (src == null && !strictUnsupported) { | ||
| // print warning | ||
|
|
| switch (decl.kind) { | ||
| case TSSyntaxKind.ClassDeclaration || | ||
| TSSyntaxKind.InterfaceDeclaration: | ||
| final outputDecl = outputDecls.first as TypeDeclaration; |
There was a problem hiding this comment.
nit: Should these by single calls instead of first here and in the below cases (besides default)?
| @@ -1527,6 +1520,17 @@ class Transformer { | |||
| bool isNotTypableDeclaration = false, | |||
| bool typeArg = false, | |||
| bool isNullable = false}) { | |||
| print(( | |||
| @@ -1613,6 +1619,12 @@ class Transformer { | |||
| } | |||
|
|
|||
| // get node finally | |||
| print(( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of fixes to the web-generator, as well as some minor additions to previous features
typedefin namespaces