Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version to txInfoSigned #30

Merged
merged 2 commits into from
Mar 25, 2024
Merged

add version to txInfoSigned #30

merged 2 commits into from
Mar 25, 2024

Conversation

jojobyte
Copy link
Contributor

createSigned inside of Tx._hashAndSignAll was not passing the version provided in the txInfo param and therefor could not adjust the version.

This is required if wanting to use DashTx.js with other cryptocurrencies.

@jojobyte jojobyte added the bug Something isn't working label Mar 24, 2024
@jojobyte jojobyte requested a review from coolaj86 March 24, 2024 04:29
@jojobyte jojobyte self-assigned this Mar 24, 2024
@coolaj86
Copy link
Member

coolaj86 commented Mar 25, 2024 •
edited
Loading

Confirmed. version was accepted by:

  • DashTx.createRaw(opts)
  • DashTx.createHashable(opts)
  • DashTx.createSigned(opts)

But the options weren't being passed all the way through. This fixes that.

@coolaj86 coolaj86 merged commit d3a3531 into main Mar 25, 2024
4 checks passed
@coolaj86
Copy link
Member

Version bumped, and pulled in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolaj86 coolaj86 coolaj86 approved these changes

Assignees

@jojobyte jojobyte

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojobyte @coolaj86