fix(lint): lint & github action updates

.github/workflows/node.js.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
 jobs:
   build:
-    name: Node.js build: fmt, ci, lint, test
+    name: 'Node.js build: fmt, ci, lint, test'
     runs-on: ubuntu-latest
     strategy:
       matrix:

index.js

@@ -2,7 +2,7 @@
 // auto-generated by `jswt reexport`
 // DO NOT EDIT
 
-module.exports = require("./lib/dashtx.js");
+module.exports = require("./dashtx.js");
 
 // these typedef reexports will be available to dependent packages
 /**

package.json

@@ -2,7 +2,7 @@
   "name": "dashtx",
   "version": "0.13.3",
   "description": "Create DASH Transactions with Vanilla JS (0 deps, cross-platform)",
-  "main": "dashtx.js",
+  "main": "index.js",
   "files": [
     "index.js",
     "dashtx.js",
@@ -18,11 +18,11 @@
   "scripts": {
     "bump": "npm version -m \"chore(release): bump to v%s\"",
     "fmt": "npm run prettier",
-    "lint": "npm run jshint && npm run tsc",
+    "lint": "npm run jshint",
     "prepublish": "npx -p [email protected] -- reexport",
     "test": "node ./tests/",
     "--------------": "-----------------------------------------------",
-    "jshint": "npx -p [email protected] -- jshint -c ./.jshintrc ./*.js ./lib",
+    "jshint": "npx -p [email protected] -- jshint -c ./.jshintrc ./*.js",
     "prettier": "npx -p [email protected] -- prettier -w '**/*.{js,md}'",
     "reexport-types": "npx -p [email protected] -- reexport",
     "tsc": "npx -p [email protected] -- tsc -p ./jsconfig.json"

tests/index.js

@@ -0,0 +1,104 @@
+"use strict";
+
+let ChildProcess = require("child_process");
+let Fs = require("node:fs/promises");
+let Path = require("node:path");
+
+async function main() {
+  console.info("TAP version 13");
+
+  let dirents = await Fs.readdir(__dirname, { withFileTypes: true });
+
+  let failures = 0;
+  let count = 0;
+  for (let dirent of dirents) {
+    if (dirent.name === "index.js") {
+      continue;
+    }
+
+    count += 1;
+    let direntPath = Path.join(__dirname, dirent.name);
+    let relPath = Path.relative(".", direntPath);
+
+    let success = await handleEach(count, relPath);
+    if (!success) {
+      failures += 1;
+    }
+  }
+
+  let passes = count - failures;
+  console.info(``);
+  console.info(`1..${count}`);
+  console.info(`# tests ${count}`);
+  console.info(`# pass  ${passes}`);
+  console.info(`# fail  ${failures}`);
+  console.info(`# skip  0`);
+
+  if (failures !== 0) {
+    process.exit(1);
+  }
+}
+
+async function handleEach(count, relPath) {
+  let success = await exec("node", [relPath])
+    .then(function (result) {
+      console.info(`ok ${count} - ${relPath}`);
+      return true;
+    })
+    .catch(function (err) {
+      console.info(`not ok ${count} - ${relPath}`);
+      if (err.code) {
+        console.info(`  # Error: ${err.code}`);
+      }
+      if (err.stderr) {
+        console.info(`  # Stderr: ${err.stderr}`);
+      }
+      return false;
+    });
+
+  return success;
+}
+
+async function exec(exe, args) {
+  return new Promise(function (resolve, reject) {
+    let cmd = ChildProcess.spawn(exe, args);
+
+    let stdout = [];
+    let stderr = [];
+
+    cmd.stdout.on("data", function (data) {
+      stdout.push(data.toString("utf8"));
+    });
+
+    cmd.stderr.on("data", function (data) {
+      stderr.push(data.toString("utf8"));
+    });
+
+    cmd.on("close", function (code) {
+      let result = {
+        code: code,
+        stdout: stdout.join(""),
+        stderr: stderr.join(""),
+      };
+
+      if (!code) {
+        resolve(result);
+        return;
+      }
+
+      let err = new Error(result.stderr);
+      Object.assign(err, result);
+      reject(err);
+    });
+  });
+}
+
+main()
+  .then(function () {
+    process.exit(0);
+  })
+  .catch(function (err) {
+    console.error("Fail:");
+    console.error(err.stack || err);
+    process.exit(1);
+  });

tx.test.js

@@ -1,6 +1,8 @@
 "use strict";
 
-let Tx = require("./tx.js");
+let Tx = require("./");
+let toVarInt = Tx.utils.toVarInt;
+let toVarIntSize = Tx.utils.toVarIntSize;
 
 /** @type {import('node:crypto')} */
 //@ts-ignore
@@ -38,6 +40,7 @@ Secp256k1.utils.hmacSha256 = async function (key, message) {
   return new Uint8Array(buffer);
 };
 
+/* jshint maxstatements: 200 */
 async function main() {
   //let expectedBytes = "00ff0ff0fff00f00";
   //let u8 = Tx.utils.hexToU8("00ff0ff0fff00f00");
@@ -61,9 +64,8 @@ async function main() {
     ],
     outputs: [
       {
-        // TODO pubkeyhash or pubKeyHash, but NOT BOTH
-        pubkeyhash: "f93af105187d21ed6adfa5d71bfada7d7324e53c",
-        units: 190968096,
+        pubKeyHash: "f93af105187d21ed6adfa5d71bfada7d7324e53c",
+        satoshis: 190968096,
       },
     ],
   };
@@ -169,21 +171,21 @@ async function main() {
     ],
     outputs: [
       {
-        pubkeyhash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
-        //pubkeyhash: "1e0a6ef6085bb8af443a9e7f8941e61deb09fb54",
-        units: quarterValue,
+        pubKeyHash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
+        //pubKeyHash: "1e0a6ef6085bb8af443a9e7f8941e61deb09fb54",
+        satoshis: quarterValue,
       },
       {
-        pubkeyhash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
-        units: quarterValue,
+        pubKeyHash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
+        satoshis: quarterValue,
       },
       {
-        pubkeyhash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
-        units: quarterValue,
+        pubKeyHash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
+        satoshis: quarterValue,
       },
       {
-        pubkeyhash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
-        units: quarterValue,
+        pubKeyHash: "5bcd0d776a7252310b9f1a7eee1a749d42126944",
+        satoshis: quarterValue,
       },
     ],
   };
@@ -267,8 +269,8 @@ async function main() {
     ],
     outputs: [
       {
-        pubkeyhash: "f93af105187d21ed6adfa5d71bfada7d7324e53c",
-        units: 190968096,
+        pubKeyHash: "f93af105187d21ed6adfa5d71bfada7d7324e53c",
+        satoshis: 190968096,
       },
     ],
   });