Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref+feat: separate to hash each input individually (for CoinJoin) #60

Merged
merged 21 commits into from
May 15, 2024
Merged

ref+feat: separate to hash each input individually (for CoinJoin) #60

merged 21 commits into from
May 15, 2024

Conversation

coolaj86
Copy link
Member

@coolaj86 coolaj86 commented Apr 27, 2024 •
edited
Loading

TODO:

  • test SIGHASH_ANYONECANPAY
  • update docs

@coolaj86 coolaj86 force-pushed the feat-parser branch 5 times, most recently from 5bbb417 to f43a49c Compare April 27, 2024 09:34
Base automatically changed from feat-parser to main April 27, 2024 09:35
This was referenced Apr 27, 2024
Closed
Open
@coolaj86 coolaj86 force-pushed the feat-sighash-one branch from 664fd27 to f8e63fd Compare May 8, 2024 21:18
coolaj86 added 16 commits May 8, 2024 21:12
@coolaj86
chore: remove leftover keys array cruft
95a5d7c
@coolaj86
fix: actually assign debug info to txInputSigned
b14b7ab
@coolaj86
fix: return signed data for signed tx
8adec17
@coolaj86
chore(release): bump to v0.16.1
7857c9d
@coolaj86
ref: rename _create => serialize
e298e47
@coolaj86
ref: .serialize(opts, sigHashType)
c51e10d
@coolaj86
ref: separate ._packInput and ._packOutput
d3de625
@coolaj86
ref: separate createRawInput, createSigHashInput
8f1b58e
@coolaj86
createRawInput => createInputRaw, createInputForSig
b1053df
@coolaj86
ref: replace .hashPartial() with .doubleSha256()
c6ddc2f
@coolaj86
ref: separate .hashAndSignInput()
78109a8
@coolaj86
ref: separate .selectSigHashInputs(), .selectSigHashOutputs()
18a39c1
@coolaj86
feat: export .serialize, .serialize{Inputs,Input,Outputs,Output}
f18ef8e
@coolaj86
ref: un-encapsulate .serialize()
1dc9b3f
@coolaj86
feat: skip signing if keyBytes === null
56e0cfc
@coolaj86
fix: track input index when partially signed
cf07f34
@coolaj86 coolaj86 changed the title WIP: feat: hash individually ref+feat: separate concerns to hash each input individually (for CoinJoin) May 9, 2024
@coolaj86 coolaj86 changed the title ref+feat: separate concerns to hash each input individually (for CoinJoin) ref+feat: separate to hash each input individually (for CoinJoin) May 9, 2024
@coolaj86 coolaj86 force-pushed the feat-sighash-one branch from f8e63fd to cf07f34 Compare May 9, 2024 07:44
@coolaj86 coolaj86 mentioned this pull request May 15, 2024
Closed
@coolaj86 coolaj86 force-pushed the feat-sighash-one branch from b036614 to 73ec1a6 Compare May 15, 2024 04:31
@coolaj86 coolaj86 merged commit 73ec1a6 into main May 15, 2024
4 checks passed
@coolaj86 coolaj86 deleted the feat-sighash-one branch May 15, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coolaj86