chore(deps): upgrade egui to 0.34.2#857
Draft
lklimek wants to merge 5 commits into
Draft
Conversation
Bump egui, eframe, egui_extras, egui_kittest from 0.33.3 to 0.34.2, and egui_commonmark from 0.22.0 to 0.23.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Rename Context::style() -> global_style() and set_style() ->
set_global_style() at every Context-receiver site (ui.ctx().style()
also collapses to ui.style(), which honours nested overrides).
- Rename SidePanel/TopBottomPanel -> Panel::{left,right,top,bottom}.
- Migrate AppState's eframe::App impl from update() to ui() and drop the
glow Context parameter from on_exit() (we ship the wgpu backend).
- Localise the remaining CentralPanel::show(ctx, …) deprecation behind
#[allow(deprecated)] inside the island_central_panel helper and the
popup-overlay sites that still need a top-level CentralPanel; this
keeps screen ui(&Context) signatures untouched.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- QA-003: rename unused `ui` parameter in `App::ui` to `_ui` so its intent (only used to extract `ctx` due to the `&Context` containment strategy) is explicit. - QA-001 / PROJ-002: add a TODO breadcrumb above `island_central_panel` documenting the deferred egui 0.35 migration to `show_inside(ui, ...)` and the eventual removal of the `#[allow(deprecated)]` containment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the egui-family dependencies from
0.33.3to0.34.2:egui,eframe,egui_extras,egui_kittest→0.34.2egui_commonmark→0.23.0(egui-0.34-compatible release)Egui 0.34 ships subtler font rendering (Skrifa + font hinting), unifies the panel API, makes AccessKit always-on, and deprecates a number of
Context-rooted call sites. Most of the diff is mechanical renames; runtime behavior is preserved.Notable API changes addressed
App::update(&mut self, ctx, frame)→App::ui(&mut self, _ui: &mut Ui, frame: &mut Frame). Body is preserved vialet ctx = _ui.ctx().clone();to keep ~250ctx-using call sites stable.Context::style()/set_style()→global_style()/set_global_style().ui.ctx().style()chains collapsed to idiomaticui.style().egui::SidePanel/TopBottomPanel→egui::Panel::{left,right,top,bottom}.egui_commonmark::CommonMarkViewerAPI unchanged in 0.23.App::on_exitsignature drops_gl: Option<&glow::Context>— the project is wgpu-only.DASH_EVO_TOOL_ACCESSIBILITYenv var preserved insrc/app.rs.Strategic deferral (debt tracked)
Panel::show(ctx, …)is deprecated in favor ofPanel::show_inside(ui, …), which would require threading&mut Uithrough 60+ screen entrypoints. To keep this PR within a focused scope, the deprecation is contained at theisland_central_panelhelper (src/ui/components/styled.rs:543) and direct call sites via narrow#[allow(deprecated)]blocks. ATODO(egui-0.35)breadcrumb documents the deferred refactor — the broader migration toshow_inside(ui, …)should land before egui's next deprecation cycle removesPanel::show(ctx, …)outright.User-visible impact
ScrollAreacontent.No functional changes to wallet, identity, DPNS, contracts, or token flows.
Commits
chore(deps): bump egui to 0.34.2— version bumps + Cargo.lockrefactor(ui): adopt egui 0.34 API renames and trait shape— mechanical renames +App::uimigrationstyle: apply nightly rustfmt after egui 0.34 refactordocs: bump egui/eframe reference in CLAUDE.md to 0.34chore(ui): address QA cosmetic findings from egui 0.34 upgrade—_uirename +TODO(egui-0.35)breadcrumbTest plan
cargo build --all-featurescleancargo +nightly fmt --all -- --checkcleancargo clippy --all-features --all-targets -- -D warningsclean (zero deprecation warnings)cargo test --all-features --workspace— 555 tests pass (468 unit + 10 e2e + 72 kittest + 3 doctests + ignored network-dependent backend-e2e)cargo test --test kittest --all-features— 72/72 kittest UI integration tests passcargo run, verify network chooser, identities screen, wallets screen, dark mode toggle, and at least one modal renders correctly under the new font rendering.Notes for reviewers
tests/backend-e2e/— the project'sAppContext::{sdk,db,wallets}()accessors anddatabase::test_helpersare gated by#[cfg(any(test, feature = "testing"))].cargo test --all-featuresresolves them; configure rust-analyzer with"rust-analyzer.cargo.features": "all"if the noise bothers you.#[allow(deprecated)]sites added — all narrowly scoped toPanel::show(ctx, …)and axis-non-agnostic Panel methods. Tracked via TODO breadcrumb atsrc/ui/components/styled.rs:543.🤖 Co-authored by Claudius the Magnificent AI Agent