Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ayush-Tibrewal
Copy link

#22

@Ayush-Tibrewal
Copy link
Author

@roshan1337d added badges added contributors photo , removed google kickstart as mentioned and add emojis that making it readme more appealing, make it under gssoc before the merge.
thank you

Copy link
Owner

@dashroshan dashroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! Great work so far ✨

I have a few suggestions for some changes.

image
I don't feel like there's much purpose to some of these badges and adds unnecessary visual noise. You can move the issues, pull requests, and commit activity ones into contributing.md file. Just keep the fork and stars in readme.md. Try looking for and adding a visits counter too that looks similar to these badges if possible. Move invite bot and support server buttons to this place and try finding a way to make those buttons look similar to the non-rounded edge ones you are using.

image
Split these into separate lines.

image
This feels redundant as there are invite bot and support server buttons already above.

image
This would probably look better if left aligned.

Happy GSSoC 🚀

@dashroshan
Copy link
Owner

@Ayush-Tibrewal it's been a while, would you like to continue working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants