Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates makefile #823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

himanshu007-creator
Copy link

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @himanshu007-creator! Just as a heads up, #821 is proposing that we fix all the warnings which are raised when the docs are built before adding the -W flag. The -W flag will turn any warnings into errors which will help prevent us from accidentally introducing new documentation which produce warnings.

@himanshu007-creator
Copy link
Author

Thanks for the PR @himanshu007-creator! Just as a heads up, #821 is proposing that we fix all the warnings which are raised when the docs are built before adding the -W flag. The -W flag will turn any warnings into errors which will help prevent us from accidentally introducing new documentation which produce warnings.

ahh!!, got it, but how exactly should we do it?

@jrbourbeau
Copy link
Member

I would build the documentation locally and try to resolve the various warnings which are raised

@himanshu007-creator
Copy link
Author

I would build the documentation locally and try to resolve the various warnings which are raised

i tried , but in step ,3 it shows error
setup.py not found

@jrbourbeau
Copy link
Member

Are you in the root of the dask-ml repo? (see https://ml.dask.org/contributing.html#cloning-the-repository)

@himanshu007-creator
Copy link
Author

Are you in the root of the dask-ml repo? (see https://ml.dask.org/contributing.html#cloning-the-repository)

yes

@jrbourbeau
Copy link
Member

Can you post the output you see when running python -m pip install?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants