Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings to import dask.ml #871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacobtomlinson
Copy link
Member

Now that dask/dask#6384 is in updated user examples to import from dask.ml instead of dask_ml.

xref #687

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobtomlinson. We'll need to wait for a dask release which includes dask/dask#6384. Additionally, this will require us to bump the minimum supported version of dask

@mmccarty
Copy link
Member

@jacobtomlinson @jrbourbeau Are we to a point where this can be merged?

@jrbourbeau
Copy link
Member

Yes, since dask/dask#6384 was included in the dask=2021.11.0 release we should be good to go. However we'll need to update our minimum support dask version to 2021.11.0 here:

"dask[array,dataframe]>=2.4.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants