Updated tutorial.rst with Python 3.6 amendment reference. #561
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated "Creating Table" section with the python 3.6 implementation of Dict() which preserves the order. Read docs for further info- https://docs.python.org/3.6/whatsnew/3.6.html#whatsnew36-pep468
adnanhemani
requested changes
Dec 23, 2022
| @@ -93,8 +93,11 @@ CSVs from URLs are also valid inputs to | |||
| ------ | |||
|
|
|||
| It's also possible to add columns from a dictionary, but this option is | |||
| discouraged because dictionaries do not preserve column order. | |||
| It's also possible to add columns from a dictionary. For users< Python 3.6 this method is discouraged because dictionary does not preserve the order. | |||
There was a problem hiding this comment.
Hi, thank you for this! We're in the middle of requiring Python 3.6 for using this library, so can you please make the change to remove this second sentence here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated "Creating Table" section with the python 3.6 implementation of Dict() which preserves the order. Read docs for further info- https://docs.python.org/3.6/whatsnew/3.6.html#whatsnew36-pep468
[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)
Changes proposed:
In Tutorial.rst file under creating table, I made a small change of adding about the recent amendment in python 3.6 where dictionaries preserve the order(new implementation of dict()). Many Students are unaware of it and thus I think that it might be a good start for students or programmers following tutorial.
Please add hacktoberfest label to this PR