BUG: at should not force overwrite in Dask when copy=None
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
gh134
branch
2 times, most recently
from
42f535d to
cec1bdf
Compare
lucascolley
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
thanks @crusaderky, LGTM! I'll merge after putting out a micro release.
Comment on lines
+174
to
+176
| # Dask's default copy value is True for bool masks, | ||
| # even if the arrays are writeable. | ||
| expect_copy = not is_writeable_array(x) or library is Backend.DASK |
There was a problem hiding this comment.
is this likely to remain the case indefinitely?
There was a problem hiding this comment.
I don't see why we should remove it. Even without Dask <=2025.1.0's bug, this PR removes an unnecessary operation. copy=None means "do whatever is best for the library and the situation...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
don't perform the unnecessary extra step of writing back to
x(which encroaches on dask/dask#11722).This PR works around a bug of Dask 2025.1.0. Starting from Dask 2025.2.0, this becomes a nice-to-have.