-
Notifications
You must be signed in to change notification settings - Fork 11
BUG: officially drop Python <3.12 #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
could you review @crusaderky ? |
LGTM It would be good to have a short summary and such in the description of the PR. I assume people who discover that they can't use Python<3.12 anymore will find this PR and wonder "what the heck?" without one. Yes, we link to the issue where this was discussed but it is a long one, with back and forth, etc. So as a service to people from the future we should have a short summary here that explains why this change was made (not why this bug fix, but why drop support for old Python versions) |
This may have to wait until after the meeting on Thursday, or whenever @ev-br is well and able to help. Personally I do not have good justification for dropping these versions instead of keeping Of course feel free to write something yourself if you do have that justification @betatim . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait until the meeting this Thursday to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It was decided in the community meeting to restore support for Python 3.10+ by bringing back @crusaderky how should we proceed here? Do we want to make a 2.4.1 release which fixes the metadata before yanking 2.4? Or can we just jump straight to 2.5? |
I think we should just issue a 2.4.1 that reintroduces |
Sounds good to me. Are you happy to make those PRs? |
gh-160