Reinstate __array__ on Python 3.10/3.11
#162
Open
+102
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Jul 11, 2025
Comment on lines
+169
to
+173
| # We arrive here from np.asarray() on Python >=3.12 when __buffer__ raises. | ||
| raise RuntimeError( | ||
| f"Can't convert array on the '{self._device}' device to a " | ||
| "NumPy array." | ||
| ) |
There was a problem hiding this comment.
Previously, np.asarray() would raise ValueError: object __array__ method not producing an array because __buffer__ raised and __array__ subtly returned None. Changed to explicit behaviour.
|
@ev-br @lucascolley ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.