Merge pull request #88 from fhoehle/fix_boto3_import

fix boto3 import by moving to classmethod
data-engineering-collective · Aug 22, 2023 · d8fb8b4 · d8fb8b4
2 parents 39972b3 + 3e067fd
commit d8fb8b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -5,6 +5,7 @@ Changelog
 =====
 * Fixed the behaviour of ``S3FSStore`` when providing a custom endpoint.
 * Added ``verify`` constructor argument to ``S3FSStore`` that disables SSL verification. Use it in an URI as ``?verify=false``.
+* Fixing ``boto3`` import at module level of `s3fsstore`.
 
 1.7.0
 =====

diff --git a/minimalkv/net/s3fsstore.py b/minimalkv/net/s3fsstore.py
@@ -2,7 +2,6 @@
 import warnings
 from typing import Dict
 
-import boto3
 from uritools import SplitResult
 
 from minimalkv import UrlMixin
@@ -129,6 +128,7 @@ def _from_parsed_url(
         store : S3FSStore
             The created S3FSStore.
         """
+        import boto3
 
         url_access_key_id = _get_username(parsed_url)
         url_secret_access_key = _get_password(parsed_url)