Support for dask 2023.9.2 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzerOnadimQC
requested review from
jtilly,
DamianB-BitFlipper,
DamianBarabonkovQC,
xhochy and
fjetter
as code owners
jtilly
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dask 2023.9.2
Previously, dask would wrap all iterators passed to
delayed()withlist()ortuple(). As of 2023.9.2, this is no longer the case, therefore, we wrap map objects withlist()before passing them intodelayed(). Also, we now explicitly set the dask dataframe shuffle method - prior to 2023.9.2 this would be set for us depending on thepyarrowversion, but this is no longer the case.The dask tests are now passing again. I also tested the changes by pip installing this branch into
quantcore.thekand running the test suite, which also passed.