Skip to content

[🍒][PLUGIN-1815] Commit/Rollback added in Committer. #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

psainics
Copy link
Contributor

@psainics psainics commented May 6, 2025

🍒 [cherrypick]

Commits :

PR:


PLUGIN-1815 In DB plugins we should commit/rollback DB transaction in commiter as currently we commit transaction even if task failed.

@vikasrathee-cs vikasrathee-cs force-pushed the cherry-pick/e00f23f51a8e6834e8e0fd680c0c6effed8ba9ed branch from 0e78d64 to 829e0e7 Compare May 6, 2025 10:30
@vikasrathee-cs vikasrathee-cs self-requested a review May 6, 2025 10:30
Copy link
Contributor

@vikasrathee-cs vikasrathee-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrathee-cs vikasrathee-cs merged commit 1770ecf into data-integrations:release/1.12 May 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants