Skip to content

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Sep 25, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

User may not call conn.close(), to avoid meaningless timeout check and heartbeat.
we can mark the query as Finished after the last page has returned for 30s and stop them.
because client retry should not take as long as result_timeout_secs.
heartbeat_handler should notify client that no need for heartbeat anymore.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 25, 2025
@youngsofun youngsofun force-pushed the query_finish branch 2 times, most recently from c0912cf to 104c8aa Compare September 25, 2025 22:05
@youngsofun youngsofun marked this pull request as draft September 26, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant