Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TestAuthDescribeFailure integration test #2420

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

anton-107
Copy link
Contributor

@anton-107 anton-107 commented Mar 3, 2025

Changes

  1. remove t.Skip directive from TestAuthDescribeFailure integration test
  2. remove checking the host in the test

Why

  1. This enables integration test that exercises databricks auth describe command, which was previously throwing errors in the CI/CD pipeline. For the nonexistent profile check to fail, we need to create a new profile file for the CLI to check (otherwise the configuration skips checking of the provided profile actually exists).
  2. I removed the assertion for the host part because it is not relevant for the test, and setting that up just required more code in the test setup.

Tests

The integration test is passing

@anton-107 anton-107 temporarily deployed to test-trigger-is March 3, 2025 15:02 — with GitHub Actions Inactive
@anton-107 anton-107 temporarily deployed to test-trigger-is March 3, 2025 15:42 — with GitHub Actions Inactive
@anton-107 anton-107 temporarily deployed to test-trigger-is March 3, 2025 16:04 — with GitHub Actions Inactive
@anton-107 anton-107 marked this pull request as ready for review March 3, 2025 16:43
Copy link
Contributor

@andrewnester andrewnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Note: we can convert this test to acceptance test instead as a followup

@anton-107 anton-107 added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@anton-107 anton-107 added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit bcce6b0 Mar 4, 2025
9 checks passed
@anton-107 anton-107 deleted the anton-107/auth-describe-failure-test branch March 4, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants