Test: test-exp-apps-mcp target #4024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
force-pushed
the
test-exp-apps-mcp
branch
from
3732fc4 to
c145f24
Compare
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: c145f24
9 failing tests:
Top 35 slowest tests (at least 2 minutes):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
## Changes A new tool `testmask` under `tools/` that determines the set of Makefile targets to run for testing. The test jobs all depend on a job that runs this tool and use its output to determine if they should run or skip. If a change only touches files under `experimental/ssh`, for example, it won't trigger the main test target. We can extend this to add more selective targets, only if we are sure that there is no dependency between the files matched for the target and other files in the repository. This, for now, relies on convention rather than strict enforcement. ### How Every file in the diff between the PR and the PR base is attributed to one of the targets. If all files map to the same target, only that target is run. If files map to multiple targets, multiple targets are run. If there are files that cannot be mapped to a specific target, then the main `test` target is run. ### Mapping to GitHub Actions This approach uses a GitHub Actions test job for every target. This results in a status check mark for each of them, making it easy to eyeball which tests ran on a PR, which tests can on main, and when they broke. Executing the same locally is straightforward because they are all named after Makefile targets. It applies to pull requests and merge queue checks. Scheduled runs and main branch pushes always run the full test suite. ## Why Not all tests need to run for every change. Being more selective reduces build times and removes noise in PRs. ## Tests The tests for this PR show it works. A new test in `tools/testmask` confirms that the targets it maps to are present in the Makefile. PRs for each of the targets: * #4023 * #4024 * #4025 * #4026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR triggers the test-exp-apps-mcp Makefile target to verify it runs correctly.