-
Notifications
You must be signed in to change notification settings - Fork 120
query tags integration #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sreekanth Vadigi <[email protected]>
Signed-off-by: Sreekanth Vadigi <[email protected]>
d61e96a
to
cf7df8d
Compare
@@ -848,10 +848,21 @@ def test_socket_timeout_user_defined(self): | |||
query = "select * from range(1000000000)" | |||
cursor.execute(query) | |||
|
|||
def test_ssp_passthrough(self): | |||
@pytest.mark.parametrize( | |||
"extra_params", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we club this test into some other e2e test? (as this may not require a separate test tbh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are actually not creating a new test, just updating the existing one to include query tags in both SEA and Thrift modes. If the existing test itself is redundant, i think we can take that up in a separate refactoring PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking as the following were not present
[
{
"use_sea": False,
},
{
"use_sea": True,
},
],
)
Let's club where this is already present (as this adds to the time taking to run all tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor nit, otherwise LGTM. Thanks for making the change
What type of PR is this?
Description
This PR adds Query Tags support to the Python SQL Connector. Query Tags allow users to attach key-value pairs to SQL executions that appear in the
system.query.history
table.Changes Made:
Created Example File (
examples/query_tags_example.py
):Enhanced Integration Test (
tests/e2e/test_driver.py
):test_ssp_passthrough()
to include Query Tags in session configurationEnhanced Unit Tests (
tests/unit/test_session.py
):test_configuration_passthrough()
test to verify query tags are properly passed through to the thrift backendtest_session_management()
to include query tags in session configuration to ensure query tags work correctly in SEA backendImplementation Details:
Added Query Tags Support in SEA flow (
src/databricks/sql/backend/sea/utils/constants.py
):"QUERY_TAGS": ""
toALLOWED_SESSION_CONF_TO_DEFAULT_VALUES_MAP
to enable query tags support in the SEA (Statement Execution API) backend flowUsage example:
How is this tested?
Testing Details:
Unit Tests:
test_configuration_passthrough()
- Verifies Query Tags flow in thrift modetest_session_management()
- Verifies Query Tags flow in SEA modeE2E Tests:
test_ssp_passthrough()
to include Query Tags in both thirft and SEA modesManual Testing:
examples/query_tags_example.py
with real backend connectionRelated Tickets & Documents