[Feature] Include column name and types in sql_table column type change error#5478
Open
moomindani wants to merge 2 commits intodatabricks:mainfrom
Open
[Feature] Include column name and types in sql_table column type change error#5478moomindani wants to merge 2 commits intodatabricks:mainfrom
moomindani wants to merge 2 commits intodatabricks:mainfrom
Conversation
…ge error When a databricks_sql_table plan fails due to a column type change, the error message now specifies which column is affected and shows the old and new types, making it easier to debug. Same improvement applied to the identity change error for consistency. Closes databricks#4919 Co-authored-by: Isaac
Co-authored-by: Isaac
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a
databricks_sql_tableplan fails due to a column type or identity change, the error message now specifies which column is affected and shows the old and new values.Before:
changing the 'type' of an existing column is not supportedAfter:
changing the 'type' of an existing column is not supported: column 'price' type changed from 'string' to 'int'Closes #4919
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfileHow it was tested
TestResourceSqlTableUpdateTable_ColumnsTypeThrowsErrorto assert the new error message includes column name and old/new types (column 'one' type changed from 'string' to 'int')TestResourceSqlTableUpdateTable_ColumnsTypeUpperLowerCaseThrowsErrorstill passes (case-insensitive comparison:stringvsSTRINGshould not error)TestResourceSqlTableUpdateTable*tests pass (column add, drop, update, membership changes, etc.)make fmt lint wspasses cleanly