-
Notifications
You must be signed in to change notification settings - Fork 14
Project linting: support for Python 3.14 and general cleanup #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This ensures that mypy understands it's intended to work this way.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage ? 79.75%
=======================================
Files ? 17
Lines ? 2411
Branches ? 521
=======================================
Hits ? 1923
Misses ? 361
Partials ? 127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 40/40 passed, 2 skipped, 1m40s total Running from acceptance #372 |
| # When enabled, pylint would attempt to guess common misconfiguration and emit | ||
| # user-friendly hints instead of false-positive error messages. | ||
| suggestion-mode = true | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was dropped because the option is no longer supported by pylint. (Version 4+ always behaves as if this option is on.)
These are backwards compatible interfaces from the standard Python APIs, and we're being compatible with later versions.
This PR upgrades the linting tools for the project: the previous versions did not work (and crashed) on Python 3.14 due to changes in the underlying bytecode format. Changes include:
None of the changes affect backward-compatibility with respect to using this package.