Skip to content

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Nov 19, 2025

This PR upgrades the linting tools for the project: the previous versions did not work (and crashed) on Python 3.14 due to changes in the underlying bytecode format. Changes include:

  • Upgrade mypy and pylint to their current versions.
  • Fixing some type-annotation issues due to the linters being stricter.
  • Updating some of the method signatures that changed in Python 3.13 but hadn't been updated, to keep the warnings from pylint across the different versions to a minimum.

None of the changes affect backward-compatibility with respect to using this package.

@asnare asnare self-assigned this Nov 19, 2025
@asnare asnare requested a review from nfx as a code owner November 19, 2025 10:05
@asnare asnare added dependencies Pull requests that update a dependency file internal do not show this PR in changelog labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 68.96552% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@ac509c1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/databricks/labs/blueprint/paths.py 57.62% 14 Missing and 11 partials ⚠️
src/databricks/labs/blueprint/cli.py 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage        ?   79.75%           
=======================================
  Files           ?       17           
  Lines           ?     2411           
  Branches        ?      521           
=======================================
  Hits            ?     1923           
  Misses          ?      361           
  Partials        ?      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

✅ 40/40 passed, 2 skipped, 1m40s total

Running from acceptance #372

Comment on lines -210 to -213
# When enabled, pylint would attempt to guess common misconfiguration and emit
# user-friendly hints instead of false-positive error messages.
suggestion-mode = true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was dropped because the option is no longer supported by pylint. (Version 4+ always behaves as if this option is on.)

@asnare asnare marked this pull request as draft November 19, 2025 10:07
@asnare asnare added this to UCX Nov 19, 2025
@asnare asnare moved this to Ready for Review in UCX Nov 19, 2025
@asnare asnare marked this pull request as ready for review November 19, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal do not show this PR in changelog

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants