Skip to content

Conversation

@m-abulazm
Copy link
Contributor

Changes

What does this PR do?

Remove redundant reconcile config

Resolves #518

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@m-abulazm m-abulazm self-assigned this Nov 17, 2025
@m-abulazm m-abulazm requested a review from a team as a code owner November 17, 2025 15:30
@m-abulazm m-abulazm added documentation Improvements or additions to documentation feat/recon making sure that remorphed query produces the same results as original labels Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.84%. Comparing base (338e93c) to head (864322f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
- Coverage   65.23%   64.84%   -0.40%     
==========================================
  Files         100      100              
  Lines        8504     8489      -15     
  Branches      875      874       -1     
==========================================
- Hits         5548     5505      -43     
- Misses       2769     2796      +27     
- Partials      187      188       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

✅ 51/51 passed, 10 flaky, 3m49s total

Flaky tests:

  • 🤪 test_validate_mixed_checks (161ms)
  • 🤪 test_validate_invalid_schema_path (0s)
  • 🤪 test_validate_successful_schema_check (178ms)
  • 🤪 test_validate_non_empty_tables (7ms)
  • 🤪 test_validate_invalid_schema_check (0s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (19.958s)
  • 🤪 test_transpiles_informatica_to_sparksql (21.247s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (21.736s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (24.74s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (3.996s)

Running from acceptance #3049

@m-abulazm m-abulazm changed the title remove redundant config params remove redundant reconcile config params Nov 17, 2025
@m-abulazm m-abulazm enabled auto-merge November 17, 2025 19:53
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feat/recon making sure that remorphed query produces the same results as original

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Enhancement of interface for experimental function for reconcile

3 participants