-
Notifications
You must be signed in to change notification settings - Fork 80
Add SQL Server Profiler #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goodwillpunning
wants to merge
12
commits into
main
Choose a base branch
from
feature/add_mssql_profiler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add SQL Server Profiler #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
===========================================
- Coverage 65.23% 13.46% -51.78%
===========================================
Files 100 105 +5
Lines 8504 8681 +177
Branches 875 875
===========================================
- Hits 5548 1169 -4379
- Misses 2769 7453 +4684
+ Partials 187 59 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 10 flaky, 4m5s total Flaky tests:
Running from acceptance #3040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR adds a new profiler for
mssql.Relevant implementation details
This profiler closely follows the implementation of the Azure Synapse profiler. However, this implementation provides a
last_execution_timeparam for allmssqlserver queries, allowing for a future scheduler component to hook in an repeat queries.Caveats/things to watch out for when reviewing:
This profiler will not support on-prem
mssqlservers.Linked issues
N/A
Functionality
databricks labs lakebridge ...Tests