-
Notifications
You must be signed in to change notification settings - Fork 80
Support catalog for databricks sources in reconcile #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
=======================================
Coverage 65.23% 65.24%
=======================================
Files 100 100
Lines 8504 8506 +2
Branches 875 876 +1
=======================================
+ Hits 5548 5550 +2
Misses 2769 2769
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 11 flaky, 3m47s total Flaky tests:
Running from acceptance #3050 |
gueniai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
asnare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think we could improve the UX by defaulting the prompt to use the default catalog, but that's not blocking.
Changes
What does this PR do?
Prompts for source catalog for databricks
Linked issues
Resolves #2140
Functionality
databricks labs lakebridge ...Tests