Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Nov 19, 2025

Changes

What does this PR do?

Prompts for source catalog for databricks

Linked issues

Resolves #2140

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.24%. Comparing base (338e93c) to head (8bd981f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   65.23%   65.24%           
=======================================
  Files         100      100           
  Lines        8504     8506    +2     
  Branches      875      876    +1     
=======================================
+ Hits         5548     5550    +2     
  Misses       2769     2769           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

✅ 51/51 passed, 11 flaky, 3m47s total

Flaky tests:

  • 🤪 test_validate_successful_schema_check (170ms)
  • 🤪 test_validate_invalid_schema_check (1ms)
  • 🤪 test_validate_non_empty_tables (6ms)
  • 🤪 test_validate_invalid_source_tech (342ms)
  • 🤪 test_validate_table_not_found (1ms)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (20.467s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (20.947s)
  • 🤪 test_transpiles_informatica_to_sparksql (21.49s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (26.366s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (6.398s)
  • 🤪 test_transpile_teradata_sql (8.098s)

Running from acceptance #3050

Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we could improve the UX by defaulting the prompt to use the default catalog, but that's not blocking.

@m-abulazm m-abulazm added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit eebf284 Dec 2, 2025
10 checks passed
@m-abulazm m-abulazm deleted the feat/recon/databricks/support-source-catalog branch December 2, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Reconciler not using provided catalog name

4 participants