Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/datachain/data_storage/db_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ def execute(
query,
cursor: Any | None = None,
conn: Any | None = None,
consistent_read: bool = False,
) -> Iterator[tuple[Any, ...]]: ...

def get_table(self, name: str) -> "Table":
Expand Down
1 change: 0 additions & 1 deletion src/datachain/data_storage/sqlite.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ def execute(
query,
cursor: sqlite3.Cursor | None = None,
conn=None,
consistent_read: bool = False,
) -> sqlite3.Cursor:
if self.is_closed:
# Reconnect in case of being closed previously.
Expand Down
6 changes: 3 additions & 3 deletions src/datachain/data_storage/warehouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ def query_count(self, query: sa.Select) -> int:
count_query = sa.select(sa.func.count(1)).select_from(query.subquery())
return next(self.db.execute(count_query))[0]

def table_rows_count(self, table, consistent_read: bool = False) -> int:
def table_rows_count(self, table) -> int:
count_query = sa.select(sa.func.count(1)).select_from(table)
return next(self.db.execute(count_query, consistent_read=consistent_read))[0]
return next(self.db.execute(count_query))[0]

def dataset_select_paginated(
self,
Expand Down Expand Up @@ -494,7 +494,7 @@ def dataset_stats(
if size_columns:
expressions = (*expressions, sa.func.sum(sum(size_columns)))
query = sa.select(*expressions)
((nrows, *rest),) = self.db.execute(query, consistent_read=True)
((nrows, *rest),) = self.db.execute(query)
return nrows, rest[0] if rest else 0

@abstractmethod
Expand Down
2 changes: 0 additions & 2 deletions src/datachain/query/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -1509,8 +1509,6 @@ def as_iterable(self, **kwargs) -> Iterator[ResultIter]:
try:
query = self.apply_steps().select()
selected_columns = [c.name for c in query.selected_columns]
if "consistent_read" not in kwargs:
kwargs["consistent_read"] = True
yield ResultIter(
self.catalog.warehouse.dataset_rows_select(query, **kwargs),
selected_columns,
Expand Down