Skip to content

Add ACS 5-year Subject Table S1251 Refresh in 2026#1915

Open
abhishekjaisw wants to merge 4 commits intodatacommonsorg:masterfrom
abhishekjaisw:S1251
Open

Add ACS 5-year Subject Table S1251 Refresh in 2026#1915
abhishekjaisw wants to merge 4 commits intodatacommonsorg:masterfrom
abhishekjaisw:S1251

Conversation

@abhishekjaisw
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the American Community Survey (ACS) 5-year Subject Table S1251 to incorporate the latest 2024 data refresh. The changes involve significant updates to the data mapping and statistical variable definitions to align with the new data, alongside a reorganization of test files for better structure.

Highlights

  • Data Refresh: Updated the ACS 5-year Subject Table S1251 to incorporate the latest 2024 data refresh.
  • Data Model Updates: Refactored statistical variable definitions in S1251_output.mcf and column_map.json by reordering properties and adding age and occupancyStatus for improved clarity and accuracy.
  • Test File Reorganization: Migrated test files from the testdata/ directory to a new test/ directory, standardizing the test file location.
  • Summary Statistics Adjustment: Updated S1251_summary.json to reflect the new 2024 data, showing a substantial increase in total StatVarObservations, dataset rows, and unique geographical units.
Changelog
  • scripts/us_census/acs5yr/subject_tables/S1251/test/S1251_output.mcf
    • Renamed from scripts/us_census/acs5yr/subject_tables/S1251/testdata/S1251_output.mcf.
    • Reordered properties for consistency.
    • Added age and occupancyStatus properties to several statistical variable definitions.
  • scripts/us_census/acs5yr/subject_tables/S1251/test/S1251_output.tmcf
    • Renamed from scripts/us_census/acs5yr/subject_tables/S1251/testdata/S1251_output.tmcf.
  • scripts/us_census/acs5yr/subject_tables/S1251/test/S1251_summary.json
    • Renamed from scripts/us_census/acs5yr/subject_tables/S1251/testdata/S1251_summary.json.
    • Updated the data year from 2012 to 2024.
    • Adjusted total StatVarObservations, number of rows in dataset, and number of unique geos to reflect the new data.
  • scripts/us_census/acs5yr/subject_tables/S1251/test/column_map.json
    • Renamed from scripts/us_census/acs5yr/subject_tables/S1251/testdata/column_map.json.
    • Updated the data year from 2012 to 2024.
    • Reordered properties and added age and occupancyStatus to statistical variable definitions.
  • scripts/us_census/acs5yr/subject_tables/S1251/testdata/S1251_cleaned.csv
    • Removed the old cleaned test data CSV file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ACS 5-year subject table S1251 data from the 2012 dataset to the 2024 dataset. The changes involve refining statistical variable definitions in S1251_output.mcf and column_map.json by reordering properties, incorporating age information into node names, and adding missing age and occupancy status properties for improved specificity. Additionally, S1251_summary.json was updated to reflect the new dataset year and the significantly increased number of observations, rows, and unique geographies, while the old 2012 CSV data output was removed.

@abhishekjaisw abhishekjaisw self-assigned this Mar 12, 2026
@saanikaaa
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants