Quoted date string when fetching obserations#1459
Merged
dwnoble merged 1 commit intodatacommonsorg:masterfrom Nov 18, 2024
Merged
Quoted date string when fetching obserations#1459dwnoble merged 1 commit intodatacommonsorg:masterfrom
dwnoble merged 1 commit intodatacommonsorg:masterfrom
Conversation
keyurva
approved these changes
Nov 18, 2024
Contributor
keyurva
left a comment
There was a problem hiding this comment.
Thanks Dan!
The fix may be a 1-liner but involved a ton of digging and troubleshooting. Thanks for figuring it out.
Tests in a follow-up PR SG.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where requesting observations for a date that contains a hyphen (Example:
2024-09) would return an empty result set.Before:
Returns
After:
Returns
TODO: Add test cases