Clean up /v1/find/entities

[n-h-diaz]

Deprecated in https://github.com/datacommonsorg/mixer/pull/1723/changes

[gemini-code-assist]

Summary of Changes

Hello @n-h-diaz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on cleaning up the codebase by removing the deprecated /v1/find/entities API endpoint. This involves deleting its protobuf definitions, generated Go code, server-side implementation, and all related test artifacts. The change aims to simplify the system by eliminating unused components. Additionally, a minor improvement was made to error logging within an existing function.

Highlights

• Deprecated API Removal: The /v1/find/entities endpoint, along with its associated protobuf messages, generated Go code, server handler, and test files, has been completely removed as it was previously deprecated.
• Codebase Cleanup: This pull request streamlines the codebase by eliminating unused and deprecated API functionality, reducing maintenance overhead.
• Improved Error Handling: Enhanced error handling in the LinkedPropertyValues function to explicitly log when an entity's name is unexpectedly missing.

Changelog

• internal/proto/recon.pb.go
  • Removed the FindEntitiesRequest message and its generated Go code.
  • Adjusted message type indices for subsequent messages due to the removal.
• internal/proto/service/mixer.pb.go
  • Removed the FindEntities RPC method from the Mixer service definition.
• internal/proto/service/mixer_grpc.pb.go
  • Removed references to Mixer_FindEntities_FullMethodName.
  • Removed the FindEntities method from the MixerClient interface.
  • Removed the FindEntities method from the MixerServer interface.
  • Removed the FindEntities method from the UnimplementedMixerServer.
  • Removed the _Mixer_FindEntities_Handler function.
  • Removed the FindEntities entry from Mixer_ServiceDesc.
• internal/server/handler.go
  • Removed the FindEntities server handler function.
• internal/server/recon/find_entities.go
  • Removed the FindEntities function implementation.
• internal/server/recon/find_entities_test.go
  • Removed the entire test file for FindEntities.
• internal/server/recon/golden/find_entities/me.json
  • Removed golden test data file.
• internal/server/recon/golden/find_entities/santa_clara_county.json
  • Removed golden test data file.
• internal/server/recon/golden/find_entities_test.go
  • Removed the golden test file for FindEntities.
• internal/server/v1/propertyvalues/linked.go
  • Added log/slog import.
  • Improved error handling for missing entity names by logging a warning.
• proto/recon.proto
  • Removed the FindEntitiesRequest protobuf message definition.
• proto/service/mixer.proto
  • Removed the FindEntities RPC definition from the Mixer service.

Activity

• No specific human activity (comments, reviews, or progress updates) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully removes the deprecated /v1/find/entities endpoint. The changes are thorough, covering the proto definitions, generated gRPC code, server handlers, and all associated tests. This is a great cleanup.

Additionally, the PR includes a valuable bug fix in internal/server/v1/propertyvalues/linked.go that prevents a potential panic, improving the code's robustness.

The changes look good to me.