Skip to content

Fix Path Traversal Vulnerabilities #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZborovskyyEpam wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Path Traversal Vulnerabilities #6007

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e505ba
Fix CWE-23 issue
AZborovskyyEpam Feb 17, 2026
f66fc1c
Fix after review
AZborovskyyEpam Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions tools/i18n/add_fallback_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,37 @@
"""

import json
import re
import sys
from pathlib import Path
from typing import Dict, Tuple

DEFAULT_LOCALE = 'en'
LOCALE_RELATIVE_PATH = 'static/js/i18n/strings/{locale}/{filename}'
LOCALE_BASE_PATH = (Path(__file__).resolve().parents[2] / 'static' / 'js' /
'i18n' / 'strings')
LOCALE_RE = re.compile(r'^[A-Za-z0-9_-]+$')
FILENAME_RE = re.compile(r'^[A-Za-z0-9._-]+$')

MessageDict = Dict[str, str]
BundleDict = Dict[str, MessageDict]


def get_validated_locale_path(locale: str, filename: str) -> Path:
if not LOCALE_RE.fullmatch(locale):
raise ValueError(f'Invalid locale: {locale}')
if not FILENAME_RE.fullmatch(filename) or '/' in filename or '\\' in filename:
raise ValueError(f'Invalid filename: {filename}')

path = (LOCALE_BASE_PATH / locale / filename).resolve()
try:
path.relative_to(LOCALE_BASE_PATH.resolve())
except ValueError as err:
raise ValueError(f'Invalid path traversal attempt: {locale}/{filename}') from err
return path


def extract_messages_from_file(locale: str, filename: str) -> BundleDict:
path = LOCALE_RELATIVE_PATH.format(locale=locale, filename=filename)
path = get_validated_locale_path(locale, filename)
with open(path, encoding='utf-8') as f:
msg_dict = json.loads(f.read())
return msg_dict
Expand All @@ -53,7 +72,7 @@ def merge_messages(default_messages: BundleDict,


def write_messages(locale: str, filename: str, locale_messages: BundleDict):
path = LOCALE_RELATIVE_PATH.format(locale=locale, filename=filename)
path = get_validated_locale_path(locale, filename)
with open(path, 'w', encoding='utf-8') as f:
json.dump(locale_messages, f, ensure_ascii=False, indent=2, sort_keys=True)

Expand Down