Skip to content

Migrate Place Info and Series Dates to V2 API #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SandeepTuniki wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Migrate Place Info and Series Dates to V2 API #6047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4f60729
Migrate PlaceInfo to V2 API and add verification tests
SandeepTuniki Feb 18, 2026
27b5843
Clean up comments and fix bug in get_series_dates
SandeepTuniki Mar 2, 2026
8951e07
Untrack verify_live_migration.py to exclude from PR
SandeepTuniki Mar 2, 2026
e2a3d92
Address review comments: Fix V2 API parsing and optimize BFS
SandeepTuniki Mar 2, 2026
1c8e04d
Fix linting and formatting issues in V2 migration files
SandeepTuniki Mar 2, 2026
d3daa46
Merge remote-tracking branch 'origin/master' into migrate-place-info-v2
SandeepTuniki Mar 16, 2026
bcd6392
fix: prioritize specific place types over administrative areas
SandeepTuniki Mar 16, 2026
5740a97
fix: hardcode United States name for country/USA to match V1 behavior
SandeepTuniki Mar 16, 2026
f768f55
style: fix python lint errors using yapf
SandeepTuniki Mar 16, 2026
4fb6f36
fix: skip bogus places in get_place_info
SandeepTuniki Mar 16, 2026
8da012e
fix: hardcode New York City name for geoId/3651000
SandeepTuniki Mar 16, 2026
6bb1972
fix: use recursive traversal in get_series_dates and update unit tests
SandeepTuniki Mar 16, 2026
ba42524
revert: remove New York City hardcoded name
SandeepTuniki Mar 16, 2026
1029f44
feat: Update goldens from Cloud Build workflow (build 276e2d55-2442-4…
datacommons-robot-author Mar 18, 2026
ac9b296
Merge remote-tracking branch 'origin/master' into migrate-place-info-…
SandeepTuniki Mar 18, 2026
1665c9c
refactor: Remove hardcoded name override for country/USA
SandeepTuniki Mar 18, 2026
9804dfd
feat: Update goldens from Cloud Build workflow (build 89397212-0490-4…
datacommons-robot-author Mar 18, 2026
1f44722
Fix: remove unused json import in migration_verification_test.py
SandeepTuniki Mar 18, 2026
cd17e63
Refactor: remove unused endpoints and move PLACE_TYPE_RANK to constants
SandeepTuniki Mar 18, 2026
8e760dc
Fix: remove unused variable 'ent' in get_series_dates
SandeepTuniki Mar 18, 2026
6d7058e
Refactor: apply minor cleanups in datacommons.py
SandeepTuniki Mar 18, 2026
eddf2cf
Test: Update webdriver event page tests to expect United States of Am…
SandeepTuniki Mar 18, 2026
908c4a7
Fix: Python style formatting in get_series_dates
SandeepTuniki Mar 18, 2026
cc0afe3
Optimize: remove unused 'value' from v2observation in get_series_dates
SandeepTuniki Mar 18, 2026
26c1c55
Fix: apply Python style formatting for v2observation call
SandeepTuniki Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/integration_tests/test_data/demo_fallback/query_1/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@
"place": {
"dcid": "geoId/0667000",
"name": "San Francisco",
"place_type": "City"
"place_type": "AdministrativeArea2"
},
"placeFallback": {},
"placeSource": "CURRENT_QUERY",
"places": [
{
"dcid": "geoId/0667000",
"name": "San Francisco",
"place_type": "City"
"place_type": "AdministrativeArea2"
},
{
"dcid": "geoId/1714000",
Expand Down
104 changes: 52 additions & 52 deletions server/integration_tests/test_data/demo_fallback/query_5/chart_config.json
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions server/integration_tests/test_data/demo_feb2023/query_8/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in Counties of United States (${date})",
"title": "High Blood Pressure in Counties of United States of America (${date})",
"type": "RANKING"
}
]
Expand All @@ -27,13 +27,13 @@
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in Counties of United States (${date})",
"title": "High Blood Pressure in Counties of United States of America (${date})",
"type": "MAP"
}
]
}
],
"title": "High Blood Pressure in Counties of United States"
"title": "High Blood Pressure in Counties of United States of America"
},
{
"columns": [
Expand All @@ -43,19 +43,19 @@
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in United States",
"title": "High Blood Pressure in United States of America",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "High Blood Pressure in United States",
"description": "High Blood Pressure in United States of America",
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in United States",
"title": "High Blood Pressure in United States of America",
"type": "HIGHLIGHT"
}
]
Expand All @@ -75,7 +75,7 @@
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States (${date})",
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States of America (${date})",
"type": "RANKING"
}
]
Expand All @@ -86,13 +86,13 @@
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States (${date})",
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States of America (${date})",
"type": "MAP"
}
]
}
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States"
"title": "Percent of Adults With Blood Pressure Who Take Medication in Counties of United States of America"
},
{
"columns": [
Expand All @@ -102,19 +102,19 @@
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in United States",
"title": "Percent of Adults With Blood Pressure Who Take Medication in United States of America",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Percent of Adults With Blood Pressure Who Take Medication in United States",
"description": "Percent of Adults With Blood Pressure Who Take Medication in United States of America",
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in United States",
"title": "Percent of Adults With Blood Pressure Who Take Medication in United States of America",
"type": "HIGHLIGHT"
}
]
Expand Down Expand Up @@ -152,15 +152,15 @@
"pastSourceContext": "",
"place": {
"dcid": "country/USA",
"name": "United States",
"name": "United States of America",
"place_type": "Country"
},
"placeFallback": {},
"placeSource": "CURRENT_QUERY",
"places": [
{
"dcid": "country/USA",
"name": "United States",
"name": "United States of America",
"place_type": "Country"
}
],
Expand Down
38 changes: 19 additions & 19 deletions server/integration_tests/test_data/demo_feb2023/query_9/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"Median_Income_Household_scatter",
"Percent_Person_WithHighBloodPressure_scatter"
],
"title": "Household Median Income (${yDate}) Vs. High Blood Pressure (${xDate}) in States of United States",
"title": "Household Median Income (${yDate}) Vs. High Blood Pressure (${xDate}) in States of United States of America",
"type": "SCATTER"
}
]
Expand All @@ -32,7 +32,7 @@
"statVarKey": [
"Median_Income_Household"
],
"title": "Household Median Income in States of United States (${date})",
"title": "Household Median Income in States of United States of America (${date})",
"type": "MAP"
}
]
Expand All @@ -47,13 +47,13 @@
"statVarKey": [
"Median_Income_Household"
],
"title": "Household Median Income in States of United States (${date})",
"title": "Household Median Income in States of United States of America (${date})",
"type": "RANKING"
}
]
}
],
"title": "Household Median Income in States of United States"
"title": "Household Median Income in States of United States of America"
},
{
"columns": [
Expand All @@ -63,7 +63,7 @@
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in States of United States (${date})",
"title": "High Blood Pressure in States of United States of America (${date})",
"type": "MAP"
}
]
Expand All @@ -78,13 +78,13 @@
"statVarKey": [
"Percent_Person_WithHighBloodPressure"
],
"title": "High Blood Pressure in States of United States (${date})",
"title": "High Blood Pressure in States of United States of America (${date})",
"type": "RANKING"
}
]
}
],
"title": "High Blood Pressure in States of United States"
"title": "High Blood Pressure in States of United States of America"
},
{
"columns": [
Expand All @@ -98,7 +98,7 @@
"Median_Income_Person_scatter",
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication_scatter"
],
"title": "Individual Median Income (${yDate}) Vs. Percent of Adults With Blood Pressure Who Take Medication (${xDate}) in States of United States",
"title": "Individual Median Income (${yDate}) Vs. Percent of Adults With Blood Pressure Who Take Medication (${xDate}) in States of United States of America",
"type": "SCATTER"
}
]
Expand All @@ -114,7 +114,7 @@
"statVarKey": [
"Median_Income_Person"
],
"title": "Individual Median Income in States of United States (${date})",
"title": "Individual Median Income in States of United States of America (${date})",
"type": "MAP"
}
]
Expand All @@ -129,13 +129,13 @@
"statVarKey": [
"Median_Income_Person"
],
"title": "Individual Median Income in States of United States (${date})",
"title": "Individual Median Income in States of United States of America (${date})",
"type": "RANKING"
}
]
}
],
"title": "Individual Median Income in States of United States"
"title": "Individual Median Income in States of United States of America"
},
{
"columns": [
Expand All @@ -145,7 +145,7 @@
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States (${date})",
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States of America (${date})",
"type": "MAP"
}
]
Expand All @@ -160,13 +160,13 @@
"statVarKey": [
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication"
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States (${date})",
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States of America (${date})",
"type": "RANKING"
}
]
}
],
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States"
"title": "Percent of Adults With Blood Pressure Who Take Medication in States of United States of America"
},
{
"columns": [
Expand All @@ -180,7 +180,7 @@
"Median_Income_Household_scatter",
"Percent_Person_18OrMoreYears_WithHighBloodPressure_ReceivedTakingBloodPressureMedication_scatter"
],
"title": "Household Median Income (${yDate}) Vs. Percent of Adults With Blood Pressure Who Take Medication (${xDate}) in States of United States",
"title": "Household Median Income (${yDate}) Vs. Percent of Adults With Blood Pressure Who Take Medication (${xDate}) in States of United States of America",
"type": "SCATTER"
}
]
Expand All @@ -200,7 +200,7 @@
"Median_Income_Person_scatter",
"Percent_Person_WithHighBloodPressure_scatter"
],
"title": "Individual Median Income (${yDate}) Vs. High Blood Pressure (${xDate}) in States of United States",
"title": "Individual Median Income (${yDate}) Vs. High Blood Pressure (${xDate}) in States of United States of America",
"type": "SCATTER"
}
]
Expand Down Expand Up @@ -265,18 +265,18 @@
"context": {},
"debug": {},
"entities": [],
"pastSourceContext": "United States",
"pastSourceContext": "United States of America",
"place": {
"dcid": "country/USA",
"name": "United States",
"name": "United States of America",
"place_type": "Country"
},
"placeFallback": {},
"placeSource": "PAST_QUERY",
"places": [
{
"dcid": "country/USA",
"name": "United States",
"name": "United States of America",
"place_type": "Country"
}
],
Expand Down
Loading
Loading