Update provenance links in browser by nick-nlb · Pull Request #6071 · datacommonsorg/website

nick-nlb · 2026-03-10T18:58:26Z

Update provenance links in browser

Issue

Description

The provenance links were previously using the URL of the source of the provenance as the link text, while the link itself correctly went to the browser entry for that provenance.

This created a confusing UI where the link the user clicked on was not the link that the user was then directed to.

The update required that the /provenance endpoint (which is only used in this place) be updated to return the name of the provenance rather than the URL.

Screenshots

Before

After

…over the URL. This required an update to the provenance endpoint to provide the information that we want, as wall as small changes to multiple files in the frontend.

gemini-code-assist · 2026-03-10T19:00:21Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a user experience issue where provenance links in the browser displayed the source URL, which could be confusing. The changes involve updating the backend API to provide a more descriptive provenance name and modifying the frontend to utilize this name for display in the UI, making the links more intuitive and user-friendly.

Highlights

Backend API Update: The /api/browser/provenance endpoint was modified to return the human-readable name of the provenance instead of its URL.
Frontend UI Enhancement: The browser's provenance links now display the provenance name, improving clarity and user experience.
Code Refactoring: Frontend components were updated to reflect the change from displaying provenance URLs/domains to displaying provenance names, including renaming relevant state and prop variables.

Changelog

server/routes/browser/api.py
- Removed unused imports (json, request, Response, server.services.datacommons).
- Imported jsonify for proper JSON response formatting.
- Modified the provenance endpoint to fetch and return the name property of provenance DCIDs instead of their url.
static/js/browser/app.tsx
- Renamed the provDomain state property to provenanceNames to accurately reflect its new content.
- Updated the logic for processing the /api/browser/provenance response to extract and store the name for each provenance.
- Passed the provenanceNames prop to child components (OutArcSection, InArcSection).
static/js/browser/arc_table_row.tsx
- Renamed the src prop to provenanceName in the ArcTableRowPropType interface.
- Adjusted the rendering condition and displayed text to use provenanceName instead of src.
static/js/browser/in_arc_section.tsx
- Updated the InArcSectionsPropType interface to use provenanceNames instead of provDomain.
- Passed the updated provenanceNames prop to InArcSubsection.
static/js/browser/in_arc_subsection.tsx
- Modified the InArcSubsectionPropType interface to use provenanceNames instead of provDomain.
- Updated the ArcTableRow component to receive provenanceName from the provenanceNames map.
static/js/browser/out_arc_section.tsx
- Changed the OutArcSectionPropType interface to use provenanceNames instead of provDomain.
- Updated the ArcTableRow component to receive provenanceName from the provenanceNames map.

Activity

The pull request was opened by nick-nlb with the title "Update provenance links in browser".
The author provided a detailed description, including a link to a buganizer issue (b/491143381).
Before and after screenshots were included in the description to visually demonstrate the UI changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the provenance links in the browser to display the provenance name instead of its URL, which improves the user interface's clarity. The backend is updated to fetch and return the provenance name, and the frontend is adjusted to consume this new data structure and display it. The changes are well-executed. I've suggested a minor simplification in the frontend code to make it more concise by removing a redundant check, taking advantage of the guarantees provided by the updated backend API.

static/js/browser/app.tsx

…es that now exist in the backend.

…tain data sources more sensible or human-readable. It currently only contains a mapping of the very common `HumanReadableStatVars` to `Data Commons`. Update tests for changes in this PR.

kmoscoe · 2026-03-10T23:38:18Z

static/js/browser/app.tsx

+/**
+ * Mapping of raw provenance names (returned by the API) to custom display names.
+ * This can be used to make certain data sources more human-readable in the UI.
+ * If a provenance name is not in this map, the original string will be used.


What does "original string" mean? Is it the DCID?

Sorry - that was unclear! The original string is the provenance name given by the API. It would only ever be a DCID if there isn't a name (although as you verified, there should always be a name).

I'll update the comment.

kmoscoe · 2026-03-10T23:55:41Z

static/js/browser/out_arc_section.tsx

    }
    const predicates = Object.keys(this.state.data);
    predicates.sort(this.predicateComparator);
    return (


I'm not sure where the best place to put this comment is, but I just thought of another consideration. We really should not show the Provenance column at all when the node is of type Provenance itself. It doesn't make sense to show a link that just links back to the same page (i.e. goes nowhere). Could we add some logic to check if the subject node is of type Provenance and then show a 2-column table consisting of property and value only?

kmoscoe · 2026-03-10T23:58:24Z

static/js/browser/in_arc_subsection.tsx

          )}
          className="arc-group-title"
        >
          <span className="mp">Subject Type: {this.props.parentType}</span>


Again, not sure where to put this comment, but if the "Subject type" is "Provenance", we shouldn't show the third column, since it will just show the same content and link as the second one. Can we put a check in for subject type "Provenance" and then render a 2-table column only?

This is now done as well. As I was doing this, I noticed that there are at least two other "special DC provenances" where the provenance name is a little unusual: ExperimentalStatVars and RawStatVars.

What do you think of doing away with the explicit override map we are using, but rather label all "dc/base/..." Provenances as Data Commons?

Is it true though?

kmoscoe · 2026-03-10T23:59:23Z

Thank you so much for this. Put a few comments in.

…

On Tue, Mar 10, 2026 at 4:15 PM Nicholas Blumberg ***@***.***> wrote: @nick-nlb <https://github.com/nick-nlb> requested your review on: datacommonsorg/website#6071 <#6071> Update provenance links in browser. — Reply to this email directly, view it on GitHub <#6071 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHMM7UHKKLGSKL3BEKZS33D4QCO2HAVCNFSM6AAAAACWNNLK6WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTGQ2TAMJXHE3DGNQ> . You are receiving this because your review was requested.Message ID: ***@***.***>

… "Provenance" and the out-arcs to hide the provenance column when the node is of type provenance. To keep the widths of the columns consistent regardless of whether there are two or three columns, the CSS now explicitly targets the provenance column for width, rather than the last column.

kmoscoe

Thanks so much! Leaving the answer to your latest question up to you. :-)

nick-nlb · 2026-03-11T20:22:14Z

Thanks so much! Leaving the answer to your latest question up to you. :-)

As per our discussion, we've gone the careful route and removed the mapping, showing the provenance names directly regardless of what they are.

Update the browser's provenance links to display the provenance name …

a158924

…over the URL. This required an update to the provenance endpoint to provide the information that we want, as wall as small changes to multiple files in the frontend.

gemini-code-assist bot reviewed Mar 10, 2026

View reviewed changes

static/js/browser/app.tsx Outdated Show resolved Hide resolved

nick-nlb added 3 commits March 10, 2026 12:34

Update the API fetch in the frontend to simplify it based on guarante…

39213a1

…es that now exist in the backend.

Add in an override map to allow the front end to selectively make cer…

28faebc

…tain data sources more sensible or human-readable. It currently only contains a mapping of the very common `HumanReadableStatVars` to `Data Commons`. Update tests for changes in this PR.

Merge branch 'master' into provenance_link_update

15adc1e

nick-nlb marked this pull request as ready for review March 10, 2026 23:02

nick-nlb requested review from beets and kmoscoe March 10, 2026 23:15

kmoscoe reviewed Mar 10, 2026

View reviewed changes

kmoscoe self-requested a review March 11, 2026 18:34

kmoscoe approved these changes Mar 11, 2026

View reviewed changes

nick-nlb added 2 commits March 11, 2026 13:19

Remove the mapping of provenance names

965e851

Merge branch 'master' into provenance_link_update

bdd87ce

nick-nlb added 2 commits March 15, 2026 18:21

Merge branch 'master' into provenance_link_update

8c46f5d

Update test to reflect final provenance name.

82d8678

beets approved these changes Mar 16, 2026

View reviewed changes

nick-nlb merged commit 517e909 into datacommonsorg:master Mar 16, 2026
12 checks passed

Conversation

nick-nlb commented Mar 10, 2026

Issue

Description

Screenshots

Before

After

Uh oh!

gemini-code-assist bot commented Mar 10, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kmoscoe Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

nick-nlb Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kmoscoe Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

nick-nlb Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kmoscoe Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

nick-nlb Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kmoscoe Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kmoscoe commented Mar 10, 2026 via email

Uh oh!

kmoscoe left a comment

Choose a reason for hiding this comment

Uh oh!

nick-nlb commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants