Conversation
CVE-2026-24049(Wheel), CVE-2026-23949(Jaraco-context), CVE-2026-21441, CVE-2025-66418, CVE-2025-66471 vunerabilites fixes
CVE-2026-24049(Wheel), CVE-2026-23949(Jaraco-context), CVE-2026-21441, CVE-2025-66418, CVE-2025-66471, CVE-2026-25990(pillow), CVE-2026-2472 and CVE-2026-2472(google-cloud-aiplatform) vunerabilites fixes
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the security posture of the CDE-Data and CDE-Runtime-services images by resolving identified vulnerabilities. It achieves this by systematically upgrading various Python and system-level dependencies within their respective Dockerfiles, ensuring that the deployed services utilize more secure and up-to-date components. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix several image vulnerabilities by upgrading Python packages in two Dockerfiles. My review focuses on ensuring these changes are implemented correctly and follow Docker best practices.
I've identified a critical issue in build/cdc_data/Dockerfile where a change breaks the virtual environment's isolation, causing packages to be installed globally. I've also provided suggestions to improve the readability and efficiency of the package installation commands in both Dockerfiles by consolidating commands and removing redundancies.
|
|
||
| # Create a virtual env, add it to path, and install all requirements. | ||
| RUN python -m venv /workspace/venv | ||
| RUN python -m venv /workspace/venv --without-pip |
There was a problem hiding this comment.
Using --without-pip creates the virtual environment without pip. As a result, the subsequent pip3 install commands on lines 53 and 57 will use the system's pip3, installing packages globally instead of within the virtual environment. This undermines the purpose of using a venv for dependency isolation.
The pip install --upgrade pip on line 82 happens after these package installations, which is too late.
To fix this, you should remove the --without-pip flag to ensure pip is part of the virtual environment from the start. If a pip upgrade is necessary, it should be done before other packages are installed.
RUN python -m venv /workspace/venv
CDE-Data and CDE-Runtime-services vunerabilites fixes
CVE-2026-24049(Wheel), CVE-2026-23949(Jaraco-context), CVE-2026-21441, CVE-2025-66418, CVE-2025-66471, CVE-2026-25990(pillow), CVE-2026-2472 and CVE-2026-2472(google-cloud-aiplatform)