Automated Integration Test Goldens Update from CI#6095
Conversation
…1f1-80c0-2922463dcc7d)
datacommons-robot-author
requested review from
a team and
clincoln8
and removed request for
a team
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating various golden files used in integration tests. These updates are automatically generated by the CI pipeline, reflecting necessary adjustments to expected outputs due to underlying data changes, improved place type definitions, or minor precision refinements in debug information. The changes ensure the test suite remains accurate and aligned with current system behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates golden test files. Most changes are minor and expected, such as updates to place names, types, and floating point precision. However, I've found a couple of potential issues in the updated chart_config.json for Mexico City. The new data includes duplicate entries for 'Tlalpan' as a child place, and the list of peer places for Mexico City is now empty, which might be a regression. Please see the specific comments for details.
| "AdministrativeArea2": [ | ||
| { | ||
| "dcid": "wikidataId/Q10832464", | ||
| "name": "Venustiano Carranza", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q14906254", | ||
| "name": "\u00c1lvaro Obreg\u00f3n", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q1832732", | ||
| "name": "Miguel Hidalgo", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q2027082", | ||
| "name": "Gustavo A. Madero", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q2356998", | ||
| "name": "Benito Ju\u00e1rez de Ochoa Quiroz", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q408181", | ||
| "name": "Tl\u00e1huac", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q408187", | ||
| "name": "Tlalpan", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q643026", | ||
| "name": "Xochimilco", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q645293", | ||
| "name": "Cuauht\u00e9moc", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q661315", | ||
| "name": "Coyoac\u00e1n", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q741771", | ||
| "name": "Iztapalapa", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q762749", | ||
| "name": "Cuajimalpa", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q780038", | ||
| "name": "La Magdalena Contreras", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q936087", | ||
| "name": "Milpa Alta", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q953866", | ||
| "name": "Tlalpan", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| }, | ||
| { | ||
| "dcid": "wikidataId/Q994867", | ||
| "name": "Azcapotzalco", | ||
| "types": [ | ||
| "AdministrativeArea2" | ||
| ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
The childPlaces list for AdministrativeArea2 contains two different entries for "Tlalpan" with different dcids (wikidataId/Q408187 and wikidataId/Q953866). This duplication might indicate an underlying data quality issue and could lead to confusion or incorrect behavior in the UI. It would be best to investigate and ensure only the correct entity for Tlalpan is included.
| ] | ||
| } | ||
| ], | ||
| "peerPlaces": [], |
There was a problem hiding this comment.
The peerPlaces list is now empty, whereas it previously contained a list of major world cities. This could be a regression. Was it intended for Mexico City to no longer have any peer places after its type changed from City to AdministrativeArea1? This might affect comparison features.
SandeepTuniki
merged commit 1029f44
into
migrate-place-info-v2-golden-updates
SandeepTuniki
deleted the
nl-golden-update-276e2d55-2442-41f1-80c0-2922463dcc7d
branch
2 participants
This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log
Edit from @SandeepTuniki: Don't review/approve. I triggered this PR creation manually (through cloudbuild) as part of my work in #6047. I'll club the changes of this PR into #6047.