Skip to content

[Don't review] Test PR for golden checks #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SandeepTuniki wants to merge 23 commits into from
Closed

[Don't review] Test PR for golden checks #6096

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4f60729
Migrate PlaceInfo to V2 API and add verification tests
SandeepTuniki Feb 18, 2026
27b5843
Clean up comments and fix bug in get_series_dates
SandeepTuniki Mar 2, 2026
8951e07
Untrack verify_live_migration.py to exclude from PR
SandeepTuniki Mar 2, 2026
e2a3d92
Address review comments: Fix V2 API parsing and optimize BFS
SandeepTuniki Mar 2, 2026
1c8e04d
Fix linting and formatting issues in V2 migration files
SandeepTuniki Mar 2, 2026
d3daa46
Merge remote-tracking branch 'origin/master' into migrate-place-info-v2
SandeepTuniki Mar 16, 2026
bcd6392
fix: prioritize specific place types over administrative areas
SandeepTuniki Mar 16, 2026
5740a97
fix: hardcode United States name for country/USA to match V1 behavior
SandeepTuniki Mar 16, 2026
f768f55
style: fix python lint errors using yapf
SandeepTuniki Mar 16, 2026
4fb6f36
fix: skip bogus places in get_place_info
SandeepTuniki Mar 16, 2026
8da012e
fix: hardcode New York City name for geoId/3651000
SandeepTuniki Mar 16, 2026
6bb1972
fix: use recursive traversal in get_series_dates and update unit tests
SandeepTuniki Mar 16, 2026
ba42524
revert: remove New York City hardcoded name
SandeepTuniki Mar 16, 2026
1029f44
feat: Update goldens from Cloud Build workflow (build 276e2d55-2442-4…
datacommons-robot-author Mar 18, 2026
ac9b296
Merge remote-tracking branch 'origin/master' into migrate-place-info-…
SandeepTuniki Mar 18, 2026
1665c9c
refactor: Remove hardcoded name override for country/USA
SandeepTuniki Mar 18, 2026
9804dfd
feat: Update goldens from Cloud Build workflow (build 89397212-0490-4…
datacommons-robot-author Mar 18, 2026
1f44722
Fix: remove unused json import in migration_verification_test.py
SandeepTuniki Mar 18, 2026
cd17e63
Refactor: remove unused endpoints and move PLACE_TYPE_RANK to constants
SandeepTuniki Mar 18, 2026
8e760dc
Fix: remove unused variable 'ent' in get_series_dates
SandeepTuniki Mar 18, 2026
6d7058e
Refactor: apply minor cleanups in datacommons.py
SandeepTuniki Mar 18, 2026
eddf2cf
Test: Update webdriver event page tests to expect United States of Am…
SandeepTuniki Mar 18, 2026
908c4a7
Fix: Python style formatting in get_series_dates
SandeepTuniki Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/integration_tests/test_data/demo_fallback/query_1/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@
"place": {
"dcid": "geoId/0667000",
"name": "San Francisco",
"place_type": "City"
"place_type": "AdministrativeArea2"
},
"placeFallback": {},
"placeSource": "CURRENT_QUERY",
"places": [
{
"dcid": "geoId/0667000",
"name": "San Francisco",
"place_type": "City"
"place_type": "AdministrativeArea2"
},
{
"dcid": "geoId/1714000",
Expand Down
2 changes: 1 addition & 1 deletion ...n_tests/test_data/detection_api_bio/whattypesofgenesarefgfr1,apoe,andache/debug_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
0.38543,
0.38534,
0.38184,
0.37971
0.3797
],
"MultiSV": {},
"Query": "what types of genes are and",
Expand Down
2 changes: 1 addition & 1 deletion ...ar/howarefactorslikeobesity,bloodpressureandasthmaimpactedbyclimatechange/debug_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
0.63385,
0.63227,
0.63222,
0.63049,
0.6305,
0.6303,
0.62984,
0.62957
Expand Down
90 changes: 45 additions & 45 deletions ...tion_tests/test_data/e2e_date_range/femalepopulationinnewyorkbefore2020/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@
"statVarKey": [
"Count_Person_Female_1145703171"
],
"title": "Women in New York",
"title": "Women in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women in New York",
"description": "Women in New York City",
"statVarKey": [
"Count_Person_Female_2019"
],
"title": "Women in New York",
"title": "Women in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -49,7 +49,7 @@
"Count_Person_Female_1145703171",
"Count_Person_Male_1145703171"
],
"title": "Population by Gender in New York",
"title": "Population by Gender in New York City",
"type": "LINE"
}
]
Expand All @@ -69,19 +69,19 @@
"statVarKey": [
"Count_Person_Female_MarriedAndNotSeparated_2369573279"
],
"title": "Non-Separated Married Women in New York",
"title": "Non-Separated Married Women in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Non-Separated Married Women in New York",
"description": "Non-Separated Married Women in New York City",
"statVarKey": [
"Count_Person_Female_MarriedAndNotSeparated_2019"
],
"title": "Non-Separated Married Women in New York",
"title": "Non-Separated Married Women in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -101,19 +101,19 @@
"statVarKey": [
"Count_Person_Female_TwoOrMoreRaces_1145703171"
],
"title": "Women Identifying as Multiracial in New York",
"title": "Women Identifying as Multiracial in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women Identifying as Multiracial in New York",
"description": "Women Identifying as Multiracial in New York City",
"statVarKey": [
"Count_Person_Female_TwoOrMoreRaces_2019"
],
"title": "Women Identifying as Multiracial in New York",
"title": "Women Identifying as Multiracial in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -133,19 +133,19 @@
"statVarKey": [
"Count_Person_3OrMoreYears_Female_EnrolledInSchool_1145703171"
],
"title": "Population: Female, Enrolled in School in New York",
"title": "Population: Female, Enrolled in School in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Population: Female, Enrolled in School in New York",
"description": "Population: Female, Enrolled in School in New York City",
"statVarKey": [
"Count_Person_3OrMoreYears_Female_EnrolledInSchool_2019"
],
"title": "Population: Female, Enrolled in School in New York",
"title": "Population: Female, Enrolled in School in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -165,19 +165,19 @@
"statVarKey": [
"Count_Person_Female_WithHealthInsurance_1704193675"
],
"title": "Women With Health Insurance in New York",
"title": "Women With Health Insurance in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women With Health Insurance in New York",
"description": "Women With Health Insurance in New York City",
"statVarKey": [
"Count_Person_Female_WithHealthInsurance_2019"
],
"title": "Women With Health Insurance in New York",
"title": "Women With Health Insurance in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -197,19 +197,19 @@
"statVarKey": [
"Count_Person_Female_FullTimeYearRoundWorker_4208561269"
],
"title": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York",
"title": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York",
"description": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York City",
"statVarKey": [
"Count_Person_Female_FullTimeYearRoundWorker_2019"
],
"title": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York",
"title": "Population: 16-64 Years, Female, Full Time Year Round Worker in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -229,19 +229,19 @@
"statVarKey": [
"Median_Age_Person_Female_3795540742"
],
"title": "Women's Median Age in New York",
"title": "Women's Median Age in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women's Median Age in New York",
"description": "Women's Median Age in New York City",
"statVarKey": [
"Median_Age_Person_Female_2019"
],
"title": "Women's Median Age in New York",
"title": "Women's Median Age in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -260,19 +260,19 @@
"statVarKey": [
"Count_Person_Female_AsianAlone_1145703171"
],
"title": "Asian Monoracial Women in New York",
"title": "Asian Monoracial Women in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Asian Monoracial Women in New York",
"description": "Asian Monoracial Women in New York City",
"statVarKey": [
"Count_Person_Female_AsianAlone_2019"
],
"title": "Asian Monoracial Women in New York",
"title": "Asian Monoracial Women in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -292,19 +292,19 @@
"statVarKey": [
"Count_Person_Female_WhiteAlone_1145703171"
],
"title": "Women Identifying as White Alone in New York",
"title": "Women Identifying as White Alone in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women Identifying as White Alone in New York",
"description": "Women Identifying as White Alone in New York City",
"statVarKey": [
"Count_Person_Female_WhiteAlone_2019"
],
"title": "Women Identifying as White Alone in New York",
"title": "Women Identifying as White Alone in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -324,19 +324,19 @@
"statVarKey": [
"Count_Person_25OrMoreYears_EducationalAttainmentBachelorsDegreeOrHigher_Female_1118952551"
],
"title": "Population: Bachelors Degree or Higher, Female in New York",
"title": "Population: Bachelors Degree or Higher, Female in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Population: Bachelors Degree or Higher, Female in New York",
"description": "Population: Bachelors Degree or Higher, Female in New York City",
"statVarKey": [
"Count_Person_25OrMoreYears_EducationalAttainmentBachelorsDegreeOrHigher_Female_2019"
],
"title": "Population: Bachelors Degree or Higher, Female in New York",
"title": "Population: Bachelors Degree or Higher, Female in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -356,19 +356,19 @@
"statVarKey": [
"Count_Person_WithDisability_Female_4281944711"
],
"title": "Women With Disabilities in New York",
"title": "Women With Disabilities in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women With Disabilities in New York",
"description": "Women With Disabilities in New York City",
"statVarKey": [
"Count_Person_WithDisability_Female_2019"
],
"title": "Women With Disabilities in New York",
"title": "Women With Disabilities in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -388,19 +388,19 @@
"statVarKey": [
"Count_Person_25OrMoreYears_EducationalAttainmentBachelorsDegree_Female_1145703171"
],
"title": "Bachelors, Women in New York",
"title": "Bachelors, Women in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Bachelors, Women in New York",
"description": "Bachelors, Women in New York City",
"statVarKey": [
"Count_Person_25OrMoreYears_EducationalAttainmentBachelorsDegree_Female_2019"
],
"title": "Bachelors, Women in New York",
"title": "Bachelors, Women in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -420,19 +420,19 @@
"statVarKey": [
"Count_Person_16OrMoreYears_Female_WithEarnings_1472009826"
],
"title": "Population: 16 Years or More, Female, With Earnings in New York",
"title": "Population: 16 Years or More, Female, With Earnings in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Population: 16 Years or More, Female, With Earnings in New York",
"description": "Population: 16 Years or More, Female, With Earnings in New York City",
"statVarKey": [
"Count_Person_16OrMoreYears_Female_WithEarnings_2019"
],
"title": "Population: 16 Years or More, Female, With Earnings in New York",
"title": "Population: 16 Years or More, Female, With Earnings in New York City",
"type": "HIGHLIGHT"
}
]
Expand All @@ -452,19 +452,19 @@
"statVarKey": [
"Count_Person_85OrMoreYears_Female_1145703171"
],
"title": "Women Over 85 in New York",
"title": "Women Over 85 in New York City",
"type": "LINE"
}
]
},
{
"tiles": [
{
"description": "Women Over 85 in New York",
"description": "Women Over 85 in New York City",
"statVarKey": [
"Count_Person_85OrMoreYears_Female_2019"
],
"title": "Women Over 85 in New York",
"title": "Women Over 85 in New York City",
"type": "HIGHLIGHT"
}
]
Expand Down Expand Up @@ -635,15 +635,15 @@
"pastSourceContext": "",
"place": {
"dcid": "geoId/3651000",
"name": "New York",
"name": "New York City",
"place_type": "City"
},
"placeFallback": {},
"placeSource": "CURRENT_QUERY",
"places": [
{
"dcid": "geoId/3651000",
"name": "New York",
"name": "New York City",
"place_type": "City"
}
],
Expand Down
Loading
Loading