Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(metadata-io/graph-service): Update lineage registry creation for dgraph and neo4j tests #13037

Merged
merged 2 commits into from
Apr 1, 2025
Merged

test(metadata-io/graph-service): Update lineage registry creation for dgraph and neo4j tests #13037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9dffa8
test(metadata-io/graph-service): Update lineage registry creation for…
asikowitz Mar 31, 2025
f91a797
Merge branch 'master' into fix-graph-service-test-entity-registry
asikowitz Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion metadata-io/src/test/java/com/linkedin/metadata/graph/dgraph/DgraphGraphServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@
import com.linkedin.metadata.aspect.models.graph.RelatedEntity;
import com.linkedin.metadata.graph.GraphService;
import com.linkedin.metadata.graph.GraphServiceTestBaseNoVia;
import com.linkedin.metadata.models.registry.ConfigEntityRegistry;
import com.linkedin.metadata.models.registry.EntityRegistryException;
import com.linkedin.metadata.models.registry.LineageRegistry;
import com.linkedin.metadata.models.registry.MergedEntityRegistry;
import com.linkedin.metadata.models.registry.SnapshotEntityRegistry;
import com.linkedin.metadata.query.filter.RelationshipDirection;
import com.linkedin.metadata.query.filter.RelationshipFilter;
import io.datahubproject.test.search.config.SearchCommonTestConfiguration;
import io.dgraph.DgraphClient;
import io.dgraph.DgraphGrpc;
import io.grpc.CallOptions;
Expand Down Expand Up @@ -69,7 +73,20 @@ public void setup() {

@BeforeMethod
public void connect() {
LineageRegistry lineageRegistry = new LineageRegistry(SnapshotEntityRegistry.getInstance());
ConfigEntityRegistry configEntityRegistry =
new ConfigEntityRegistry(
SearchCommonTestConfiguration.class
.getClassLoader()
.getResourceAsStream("entity-registry.yml"));
SnapshotEntityRegistry snapshotEntityRegistry = SnapshotEntityRegistry.getInstance();
LineageRegistry lineageRegistry;
try {
MergedEntityRegistry mergedEntityRegistry =
new MergedEntityRegistry(snapshotEntityRegistry).apply(configEntityRegistry);
lineageRegistry = new LineageRegistry(mergedEntityRegistry);
} catch (EntityRegistryException e) {
throw new RuntimeException(e);
}
_channel =
ManagedChannelBuilder.forAddress(_container.getHost(), _container.getGrpcPort())
.usePlaintext()
Expand Down
24 changes: 21 additions & 3 deletions metadata-io/src/test/java/com/linkedin/metadata/graph/neo4j/Neo4jGraphServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,17 @@
import com.linkedin.metadata.graph.GraphServiceTestBaseNoVia;
import com.linkedin.metadata.graph.LineageDirection;
import com.linkedin.metadata.graph.RelatedEntitiesResult;
import com.linkedin.metadata.models.registry.ConfigEntityRegistry;
import com.linkedin.metadata.models.registry.EntityRegistryException;
import com.linkedin.metadata.models.registry.LineageRegistry;
import com.linkedin.metadata.models.registry.MergedEntityRegistry;
import com.linkedin.metadata.models.registry.SnapshotEntityRegistry;
import com.linkedin.metadata.query.LineageFlags;
import com.linkedin.metadata.query.filter.RelationshipDirection;
import com.linkedin.metadata.query.filter.RelationshipFilter;
import io.datahubproject.metadata.context.OperationContext;
import io.datahubproject.test.metadata.context.TestOperationContexts;
import io.datahubproject.test.search.config.SearchCommonTestConfiguration;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
Expand Down Expand Up @@ -55,9 +59,23 @@ public void init() {
_serverBuilder = new Neo4jTestServerBuilder();
_serverBuilder.newServer();
_driver = GraphDatabase.driver(_serverBuilder.boltURI());
_client =
new Neo4jGraphService(
operationContext, new LineageRegistry(SnapshotEntityRegistry.getInstance()), _driver);

ConfigEntityRegistry configEntityRegistry =
new ConfigEntityRegistry(
SearchCommonTestConfiguration.class
.getClassLoader()
.getResourceAsStream("entity-registry.yml"));
SnapshotEntityRegistry snapshotEntityRegistry = SnapshotEntityRegistry.getInstance();
LineageRegistry lineageRegistry;
try {
MergedEntityRegistry mergedEntityRegistry =
new MergedEntityRegistry(snapshotEntityRegistry).apply(configEntityRegistry);
lineageRegistry = new LineageRegistry(mergedEntityRegistry);
} catch (EntityRegistryException e) {
throw new RuntimeException(e);
}

_client = new Neo4jGraphService(operationContext, lineageRegistry, _driver);
_client.clear();
}

Expand Down
Loading