Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated StyledTable to match the table component until we can update … #13043

Conversation

annadoesdesign
Copy link
Contributor

@annadoesdesign annadoesdesign commented Mar 31, 2025

Updated styling for all the tables until we can update the actual table component

Before:
Screenshot 2025-03-31 at 3 11 57 PM
Screenshot 2025-03-31 at 3 11 56 PM
Screenshot 2025-03-31 at 3 11 52 PM
Screenshot 2025-03-31 at 3 11 49 PM
Screenshot 2025-03-31 at 3 11 45 PM

After:
Screenshot 2025-03-31 at 3 11 25 PM
Screenshot 2025-03-31 at 3 11 23 PM
Screenshot 2025-03-31 at 3 11 20 PM
Screenshot 2025-03-31 at 3 11 18 PM
Screenshot 2025-03-31 at 3 11 14 PM
Screenshot 2025-03-31 at 3 11 10 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 31, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 31, 2025
… that maintains visual clipping but is more test-friendly

Added min-height: 100px to ensure table content is always visible to Cypress
Set up proper positioning context with position: relative and z-index
Maintained proper scrolling behavior while keeping elements visible
Removed any display: none that might hide elements from Cypress
@annadoesdesign
Copy link
Contributor Author

causing issues with ingestion source table closing branch and updating individual tables one at a time

@annadoesdesign annadoesdesign deleted the ae--des-313-styled-table-update branch April 2, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant